Commit 124fe7fb authored by Markus Armbruster's avatar Markus Armbruster Committed by Michael Tokarev
Browse files

libcacard: Plug memory leaks around vreader_get_reader_list() 



Spotted by Coverity.

Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Reviewed-by: default avatarAlon Levy <alevy@redhat.com>
Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
parent d357e3d9

libcacard/vcard_emul_nss.c

+4 −0
Original line number Diff line number Diff line
@@ -433,11 +433,13 @@ vcard_emul_find_vreader_from_slot(PK11SlotInfo *slot) 
        VReader *reader = vreader_list_get_reader(current_entry);

        VReaderEmul *reader_emul = vreader_get_private(reader);

        if (reader_emul->slot == slot) {

            vreader_list_delete(reader_list);

            return reader;

        }

        vreader_free(reader);

    }



    vreader_list_delete(reader_list);

    return NULL;

}
@@ -1059,6 +1061,8 @@ vcard_emul_replay_insertion_events(void) 
        next_entry = vreader_list_get_next(current_entry);

        vreader_queue_card_event(vreader);

    }



    vreader_list_delete(list);

}



/*

libcacard/vscclient.c

+1 −0
Original line number Diff line number Diff line
@@ -570,6 +570,7 @@ do_command(GIOChannel *source, 
                       "CARD_PRESENT" : "            ",

                       vreader_get_name(reader));

            }

            vreader_list_delete(list);

        } else if (*string != 0) {

            printf("valid commands:\n");

            printf("insert [reader_id]\n");