Commit 120eee7d authored by Eduardo Habkost's avatar Eduardo Habkost Committed by Andreas Färber
Browse files

target-i386: Set migratable=yes by default on "host" CPU mooel 



Having only migratable flags reported by default on the "host" CPU model
is safer for the following reasons:

 * Existing users may expect "-cpu host" to be migration-safe, if they
   take care of always using compatible host CPUs, host kernels, and
   QEMU versions.
 * Users who don't care aboug migration and want to enable all features
   supported by the host kernel can simply change their setup to use
   migratable=no.

Without this change, people using "-cpu host" will stop being able to
migrate, because now "invtsc" is getting enabled by default.

We are not setting migratable=yes by default on all X86CPU subclasses,
because users should be able to get non-migratable features enabled if
they ask for them explicitly.

Reviewed-by: default avatarMarcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
Signed-off-by: default avatarAndreas Färber <afaerber@suse.de>
parent 84f1b92f

target-i386/cpu.c

+1 −1
Original line number Diff line number Diff line
@@ -1221,7 +1221,7 @@ static int cpu_x86_fill_model_id(char *str) 
static X86CPUDefinition host_cpudef;



static Property host_x86_cpu_properties[] = {

    DEFINE_PROP_BOOL("migratable", X86CPU, migratable, false),

    DEFINE_PROP_BOOL("migratable", X86CPU, migratable, true),

    DEFINE_PROP_END_OF_LIST()

};