Commit 11e732a5 authored by Paolo Bonzini's avatar Paolo Bonzini
Browse files

address_space_access_valid: address_space_to_flatview needs RCU lock 



address_space_access_valid is calling address_space_to_flatview but it can
be called outside the RCU lock.  To fix it, push the rcu_read_lock/unlock
pair up from flatview_access_valid to address_space_access_valid.

Reviewed-by: default avatarAlexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent b2a44fca

exec.c

+8 −4
Original line number Diff line number Diff line
@@ -3395,7 +3395,6 @@ static bool flatview_access_valid(FlatView *fv, hwaddr addr, int len, 
    MemoryRegion *mr;

    hwaddr l, xlat;



    rcu_read_lock();

    while (len > 0) {

        l = len;

        mr = flatview_translate(fv, addr, &xlat, &l, is_write);
@@ -3410,15 +3409,20 @@ static bool flatview_access_valid(FlatView *fv, hwaddr addr, int len, 
        len -= l;

        addr += l;

    }

    rcu_read_unlock();

    return true;

}



bool address_space_access_valid(AddressSpace *as, hwaddr addr,

                                int len, bool is_write)

{

    return flatview_access_valid(address_space_to_flatview(as),

                                 addr, len, is_write);

    FlatView *fv;

    bool result;



    rcu_read_lock();

    fv = address_space_to_flatview(as);

    result = flatview_access_valid(fv, addr, len, is_write);

    rcu_read_unlock();

    return result;

}



static hwaddr