Commit 11bfdbdf authored by Richard Henderson's avatar Richard Henderson Committed by Alex Bennée
Browse files

target/alpha: Tidy helper_fp_exc_raise_s



Remove a redundant masking of ignore.  Once that's gone it is
obvious that the system-mode inner test is redundant with the
outer test.  Move the fpcr_exc_enable masking up and tidy.

No functional change.

Signed-off-by: default avatarRichard Henderson <richard.henderson@linaro.org>
Signed-off-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20190921043256.4575-8-richard.henderson@linaro.org>
parent 80093070
Loading
Loading
Loading
Loading
+4 −11
Original line number Diff line number Diff line
@@ -90,25 +90,18 @@ void helper_fp_exc_raise_s(CPUAlphaState *env, uint32_t ignore, uint32_t regno)
    uint32_t exc = env->error_code & ~ignore;
    if (exc) {
        env->fpcr |= exc;
        exc &= ~ignore;
#ifdef CONFIG_USER_ONLY
        /*
         * In user mode, the kernel's software handler only
         * delivers a signal if the exception is enabled.
         */
        if (!(exc & env->fpcr_exc_enable)) {
            return;
        }
#else
        exc &= env->fpcr_exc_enable;
        /*
         * In system mode, the software handler gets invoked
         * for any non-ignored exception.
         * In user mode, the kernel's software handler only
         * delivers a signal if the exception is enabled.
         */
#ifdef CONFIG_USER_ONLY
        if (!exc) {
            return;
        }
#endif
        exc &= env->fpcr_exc_enable;
        fp_exc_raise1(env, GETPC(), exc, regno, EXC_M_SWC);
    }
}