Commit 110571be authored by Vladimir Sementsov-Ogievskiy's avatar Vladimir Sementsov-Ogievskiy Committed by Max Reitz
Browse files

block/backup: disable copy_range for compressed backup 



Enabled by default copy_range ignores compress option. It's definitely
unexpected for user.

It's broken since introduction of copy_range usage in backup in
9ded4a01.

Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-id: 20190730163251.755248-3-vsementsov@virtuozzo.com
Reviewed-by: default avatarJohn Snow <jsnow@redhat.com>
Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
parent 19ba4651

block/backup.c

+1 −1
Original line number Diff line number Diff line
@@ -657,7 +657,7 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs, 
    job->cluster_size = cluster_size;

    job->copy_bitmap = copy_bitmap;

    copy_bitmap = NULL;

    job->use_copy_range = true;

    job->use_copy_range = !compress; /* compression isn't supported for it */

    job->copy_range_size = MIN_NON_ZERO(blk_get_max_transfer(job->common.blk),

                                        blk_get_max_transfer(job->target));

    job->copy_range_size = MAX(job->cluster_size,