Commit 10d6eda1 authored by Peter Maydell's avatar Peter Maydell Committed by Max Reitz
Browse files

qemu-img: Avoid setting ret to unused value in img_convert() 



Coverity points out that we assign the return value from
bdrv_snapshot_load_tmp() to 'ret' in img_convert(), but then
never use that variable. (We check for failure by looking
at local_err instead.) Drop the unused assignment, bringing
the call into line with the following call to
bdrv_snapshot_laod_tmp_by_id_or_name().

(Fixes CID 1247240.)

Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Message-id: 1486744104-15590-3-git-send-email-peter.maydell@linaro.org
Reviewed-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
parent 8b3c6792

qemu-img.c

+4 −4
Original line number Diff line number Diff line
@@ -1968,7 +1968,7 @@ static int img_convert(int argc, char **argv) 
    }



    if (sn_opts) {

        ret = bdrv_snapshot_load_tmp(bs[0],

        bdrv_snapshot_load_tmp(bs[0],

                               qemu_opt_get(sn_opts, SNAPSHOT_OPT_ID),

                               qemu_opt_get(sn_opts, SNAPSHOT_OPT_NAME),

                               &local_err);