Commit 10689e36 authored by Markus Armbruster's avatar Markus Armbruster
Browse files

tests/qapi-schema: Cover non-string, non-dictionary members 



We always report "should be a dictionary" then.  This is misleading:
when allow_dict, it can be a dictionary or a type name string, else it
can only be a type name.

Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
parent 91f9816d

tests/Makefile

+2 −0
Original line number Diff line number Diff line
@@ -229,12 +229,14 @@ check-qapi-schema-y := $(addprefix tests/qapi-schema/, \ 
	redefined-type.json redefined-command.json redefined-builtin.json \

	redefined-event.json command-int.json bad-data.json event-max.json \

	type-bypass.json type-bypass-no-gen.json type-bypass-bad-gen.json \

	args-invalid.json \

	args-array-empty.json args-array-unknown.json args-int.json \

	args-unknown.json args-member-unknown.json args-member-array.json \

	args-member-array-bad.json args-alternate.json args-union.json \

	returns-array-bad.json returns-int.json returns-dict.json \

	returns-unknown.json returns-alternate.json returns-whitelist.json \

	missing-colon.json missing-comma-list.json missing-comma-object.json \

	struct-data-invalid.json struct-member-invalid.json \

	nested-struct-data.json non-objects.json \

	qapi-schema-test.json quoted-structural-chars.json \

	leading-comma-list.json leading-comma-object.json \

tests/qapi-schema/args-invalid.err

0 → 100644
+1 −0
Original line number Diff line number Diff line 
tests/qapi-schema/args-invalid.json:2: 'data' for command 'foo' should be a dictionary

tests/qapi-schema/args-invalid.exit

0 → 100644
+1 −0
Original line number Diff line number Diff line 
1

tests/qapi-schema/args-invalid.json

0 → 100644
+3 −0
Original line number Diff line number Diff line 
# FIXME error "should be a dictionary" is misleading, type name is also fine

{ 'command': 'foo',

  'data': false }

tests/qapi-schema/args-invalid.out

0 → 100644
+0 −0

Empty file added.