Commit 100b5e01 authored by Richard Henderson's avatar Richard Henderson
Browse files

tcg: Put target helper data into an array. 



One call inside of a loop to tcg_register_helper instead of hundreds
of sequential calls.

Presumably more icache and branch prediction friendly; resulting binary
size mostly unchanged on x86_64, as we're trading 32-bit rip-relative
references in .text for full 64-bit pointers in .rodata.

Signed-off-by: default avatarRichard Henderson <rth@twiddle.net>
parent f5daeec4

include/exec/def-helper.h

+1 −2
Original line number Diff line number Diff line
@@ -240,8 +240,7 @@ static inline void glue(gen_helper_, name)(dh_retvar_decl(ret) \ 
#elif GEN_HELPER == 2

/* Register helpers.  */



#define DEF_HELPER_FLAGS_0(name, flags, ret) \

tcg_register_helper(HELPER(name), #name);

#define DEF_HELPER_FLAGS_0(name, flags, ret)  { HELPER(name), #name },



#define DEF_HELPER_FLAGS_1(name, flags, ret, t1) \

DEF_HELPER_FLAGS_0(name, flags, ret)

tcg/tcg.c

+14 −3
Original line number Diff line number Diff line
@@ -256,9 +256,19 @@ void tcg_pool_reset(TCGContext *s) 


#include "helper.h"



typedef struct TCGHelperInfo {

    void *func;

    const char *name;

} TCGHelperInfo;



static const TCGHelperInfo all_helpers[] = {

#define GEN_HELPER 2

#include "helper.h"

};



void tcg_context_init(TCGContext *s)

{

    int op, total_args, n;

    int op, total_args, n, i;

    TCGOpDef *def;

    TCGArgConstraint *args_ct;

    int *sorted_args;
@@ -288,8 +298,9 @@ void tcg_context_init(TCGContext *s) 
    }



    /* Register helpers.  */

#define GEN_HELPER 2

#include "helper.h"

    for (i = 0; i < ARRAY_SIZE(all_helpers); ++i) {

        tcg_register_helper(all_helpers[i].func, all_helpers[i].name);

    }



    tcg_target_init(s);

}