Commit 0f8b09b2 authored by Sandra Loosemore's avatar Sandra Loosemore Committed by Peter Maydell
Browse files

gdbstub: Send a reply to the vKill packet. 

Per the GDB remote protocol documentation

https://sourceware.org/gdb/current/onlinedocs/gdb/Packets.html#index-vKill-packet



the debug stub is expected to send a reply to the 'vKill' packet.  At
least some versions of GDB crash if the gdb stub simply exits without
sending a reply.  This patch fixes QEMU's gdb stub to conform to the
expected behavior.

Note that QEMU's existing handling of the legacy 'k' packet is
correct: in that case GDB does not expect a reply, and QEMU does not
send one.

Signed-off-by: default avatarSandra Loosemore <sandra@codesourcery.com>
Message-id: 1550008033-26540-1-git-send-email-sandra@codesourcery.com
Reviewed-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
parent d8efe78e

gdbstub.c

+1 −0
Original line number Diff line number Diff line
@@ -1361,6 +1361,7 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) 
            break;

        } else if (strncmp(p, "Kill;", 5) == 0) {

            /* Kill the target */

            put_packet(s, "OK");

            error_report("QEMU: Terminated via GDBstub");

            exit(0);

        } else {