Commit 0f5a15e4 authored by Ladi Prosek's avatar Ladi Prosek Committed by Gerd Hoffmann
Browse files

virtio-input: free event queue when finalizing 



VirtIOInput.queue was never freed. This commit adds an explicit
g_free to virtio_input_finalize and switches the allocation
function from realloc to g_realloc in virtio_input_send.

Signed-off-by: default avatarLadi Prosek <lprosek@redhat.com>
Message-id: 1490365490-4854-2-git-send-email-lprosek@redhat.com
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent ea2afcf5

hw/input/virtio-input.c

+4 −2
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ void virtio_input_send(VirtIOInput *vinput, virtio_input_event *event) 
    /* queue up events ... */

    if (vinput->qindex == vinput->qsize) {

        vinput->qsize++;

        vinput->queue = realloc(vinput->queue, vinput->qsize *

        vinput->queue = g_realloc(vinput->queue, vinput->qsize *

                                  sizeof(virtio_input_event));

    }

    vinput->queue[vinput->qindex++] = *event;
@@ -272,6 +272,8 @@ static void virtio_input_finalize(Object *obj) 
        QTAILQ_REMOVE(&vinput->cfg_list, cfg, node);

        g_free(cfg);

    }



    g_free(vinput->queue);

}

static void virtio_input_device_unrealize(DeviceState *dev, Error **errp)

{