Commit 0eaf453e authored by Raphael Pour's avatar Raphael Pour Committed by Eric Blake
Browse files

qemu-nbd: Close inherited stderr 



Close inherited stderr of the parent if fork_process is false.
Otherwise no one will close it. (introduced by e6df58a5)

This only affected 'qemu-nbd -c /dev/nbd0'.

Signed-off-by: default avatarRaphael Pour <raphael.pour@hetzner.com>
Message-Id: <d8ddc993-9816-836e-a3de-c6edab9d9c49@hetzner.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
[eblake: Enhance commit message]
Signed-off-by: default avatarEric Blake <eblake@redhat.com>
parent debe78ce

qemu-nbd.c

+5 −1
Original line number Diff line number Diff line
@@ -916,7 +916,11 @@ int main(int argc, char **argv) 
        } else if (pid == 0) {

            close(stderr_fd[0]);



            /* Remember parent's stderr if we will be restoring it. */

            if (fork_process) {

                old_stderr = dup(STDERR_FILENO);

            }



            ret = qemu_daemon(1, 0);



            /* Temporarily redirect stderr to the parent's pipe...  */