Commit 0e22a2d1 authored May 30, 2013 by Stefan Hajnoczi Committed by Paolo Bonzini Jun 18, 2013

vhost-scsi: fix k->set_guest_notifiers() NULL dereference

Coverity picked up a copy-paste bug.  In vhost_scsi_start() we check for
!k->set_guest_notifiers and error out.  The check probably got copied
but instead of erroring we actually use the function pointer!

Cc: Nicholas Bellinger <nab@linux-iscsi.org>
Cc: Asias He <asias@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent 18e673b8

hw/scsi/vhost-scsi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -123,7 +123,7 @@ static void vhost_scsi_stop(VHostSCSI *s)
		VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus);
		int ret = 0;

		if (!k->set_guest_notifiers) {
		if (k->set_guest_notifiers) {
		ret = k->set_guest_notifiers(qbus->parent, s->dev.nvqs, false);
		if (ret < 0) {
		error_report("vhost guest notifier cleanup failed: %d\n", ret);