Commit 0d1e8d6f authored by Marc-André Lureau's avatar Marc-André Lureau Committed by Gerd Hoffmann
Browse files

Revert "bus: do not unref the added child bus on realize" 



This is wrong.  object_finalize_child_property()'s unref balances the
ref in object_property_add_child().  qbus_realize's unref balances the
ref that was initially placed by object_new/object_initialize.

This reverts commit f3d58385.

Reported-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Signed-off-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 20180613172815.32738-4-marcandre.lureau@redhat.com
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent 9b5c2fd5

hw/core/bus.c

+1 −0
Original line number Diff line number Diff line
@@ -102,6 +102,7 @@ static void qbus_realize(BusState *bus, DeviceState *parent, const char *name) 
        QLIST_INSERT_HEAD(&bus->parent->child_bus, bus, sibling);

        bus->parent->num_child_bus++;

        object_property_add_child(OBJECT(bus->parent), bus->name, OBJECT(bus), NULL);

        object_unref(OBJECT(bus));

    } else if (bus != sysbus_get_default()) {

        /* TODO: once all bus devices are qdevified,

           only reset handler for main_system_bus should be registered here. */