Commit 0d0d309d authored by Richard Henderson's avatar Richard Henderson
Browse files

tcg: Minor adjustments to deposit expanders 



Assert that len is not 0.

Since we have asserted that ofs + len <= N, a later
check for len == N implies that ofs == 0.

Reviewed-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Signed-off-by: default avatarRichard Henderson <rth@twiddle.net>
parent 7ec8bab3

tcg/tcg-op.c

+4 −2
Original line number Diff line number Diff line
@@ -533,10 +533,11 @@ void tcg_gen_deposit_i32(TCGv_i32 ret, TCGv_i32 arg1, TCGv_i32 arg2, 
    TCGv_i32 t1;



    tcg_debug_assert(ofs < 32);

    tcg_debug_assert(len > 0);

    tcg_debug_assert(len <= 32);

    tcg_debug_assert(ofs + len <= 32);



    if (ofs == 0 && len == 32) {

    if (len == 32) {

        tcg_gen_mov_i32(ret, arg2);

        return;

    }
@@ -1718,10 +1719,11 @@ void tcg_gen_deposit_i64(TCGv_i64 ret, TCGv_i64 arg1, TCGv_i64 arg2, 
    TCGv_i64 t1;



    tcg_debug_assert(ofs < 64);

    tcg_debug_assert(len > 0);

    tcg_debug_assert(len <= 64);

    tcg_debug_assert(ofs + len <= 64);



    if (ofs == 0 && len == 64) {

    if (len == 64) {

        tcg_gen_mov_i64(ret, arg2);

        return;

    }