Commit 0cd089e9 authored by Phil Dennis-Jordan's avatar Phil Dennis-Jordan Committed by Gerd Hoffmann
Browse files

hw/usb/dev-hid: Improve guest compatibility of usb-tablet 



 1. Set bInterfaceProtocol to 0x00 for usb-tablet. This should be
    non-zero for boot protocol devices only, which the usb-tablet is not.
 2. Set the usb-tablet's usage to "mouse" in the report descriptor.

The boot protocol of 0x02 specifically confused OS X/macOS' HID driver
stack, causing it to generate additional bogus HID events with relative
motion in addition to the tablet's absolute coordinate events.

Absolute pointing devices with HID Report Descriptor usage of 0x01
(pointing) are treated by the macOS HID driver as analog sticks, and
absolute coordinates are not directly translated to absolute mouse
cursor positions. Changing it to 0x02 (mouse) fixes the problem, and
does not have any adverse effect in other operating systems and
windowing systems. (VMWare does the same thing.)

Signed-off-by: default avatarPhil Dennis-Jordan <phil@philjordan.eu>
Message-id: 1485365075-32702-1-git-send-email-phil@philjordan.eu
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent a951316b

hw/usb/dev-hid.c

+3 −3
Original line number Diff line number Diff line
@@ -144,7 +144,7 @@ static const USBDescIface desc_iface_tablet = { 
    .bInterfaceNumber              = 0,

    .bNumEndpoints                 = 1,

    .bInterfaceClass               = USB_CLASS_HID,

    .bInterfaceProtocol            = 0x02,

    .bInterfaceProtocol            = 0x00,

    .ndesc                         = 1,

    .descs = (USBDescOther[]) {

        {
@@ -174,7 +174,7 @@ static const USBDescIface desc_iface_tablet2 = { 
    .bInterfaceNumber              = 0,

    .bNumEndpoints                 = 1,

    .bInterfaceClass               = USB_CLASS_HID,

    .bInterfaceProtocol            = 0x02,

    .bInterfaceProtocol            = 0x00,

    .ndesc                         = 1,

    .descs = (USBDescOther[]) {

        {
@@ -487,7 +487,7 @@ static const uint8_t qemu_mouse_hid_report_descriptor[] = { 


static const uint8_t qemu_tablet_hid_report_descriptor[] = {

    0x05, 0x01,		/* Usage Page (Generic Desktop) */

    0x09, 0x01,		/* Usage (Pointer) */

    0x09, 0x02,		/* Usage (Mouse) */

    0xa1, 0x01,		/* Collection (Application) */

    0x09, 0x01,		/*   Usage (Pointer) */

    0xa1, 0x00,		/*   Collection (Physical) */