Commit 0c2f6e7e authored by Daniel P. Berrangé's avatar Daniel P. Berrangé Committed by Paolo Bonzini
Browse files

opts: remove redundant check for NULL parameter 



No callers of get_opt_value() pass in a NULL for the "value" parameter,
so the check is redundant.

Signed-off-by: default avatarDaniel P. Berrangé <berrange@redhat.com>
Message-Id: <20180514171913.17664-4-berrange@redhat.com>
Reviewed-by: default avatarEduardo Habkost <ehabkost@redhat.com>
Tested-by: default avatarRoman Kagan <rkagan@virtuozzo.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent f8da93a0

util/qemu-option.c

+4 −8
Original line number Diff line number Diff line
@@ -75,20 +75,16 @@ const char *get_opt_value(const char *p, char **value) 
    size_t capacity = 0, length;

    const char *offset;



    if (value) {

    *value = NULL;

    }

    while (1) {

        offset = qemu_strchrnul(p, ',');

        length = offset - p;

        if (*offset != '\0' && *(offset + 1) == ',') {

            length++;

        }

        if (value) {

        *value = g_renew(char, *value, capacity + length + 1);

        strncpy(*value + capacity, p, length);

        (*value)[capacity + length] = '\0';

        }

        capacity += length;

        if (*offset == '\0' ||

            *(offset + 1) != ',') {