Commit 0be4e886 authored by David Gibson's avatar David Gibson
Browse files

spapr: Change DRC attach & detach methods to functions 



DRC objects have attach & detach methods, but there's only one
implementation.  Although there are some differences in its behaviour for
different DRC types, the overall structure is the same, so while we might
want different method implementations for some parts, we're unlikely to
want them for the top-level functions.

So, replace them with direct function calls.

Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
Reviewed-by: default avatarMichael Roth <mdroth@linux.vnet.ibm.com>
Acked-by: default avatarMichael Roth <mdroth@linux.vnet.ibm.com>
parent cd74d27e

hw/ppc/spapr.c

+6 −13
Original line number Diff line number Diff line
@@ -2523,7 +2523,6 @@ static void spapr_add_lmbs(DeviceState *dev, uint64_t addr_start, uint64_t size, 
                           Error **errp)

{

    sPAPRDRConnector *drc;

    sPAPRDRConnectorClass *drck;

    uint32_t nr_lmbs = size/SPAPR_MEMORY_BLOCK_SIZE;

    int i, fdt_offset, fdt_size;

    void *fdt;
@@ -2538,10 +2537,10 @@ static void spapr_add_lmbs(DeviceState *dev, uint64_t addr_start, uint64_t size, 
        fdt_offset = spapr_populate_memory_node(fdt, node, addr,

                                                SPAPR_MEMORY_BLOCK_SIZE);



        drck = SPAPR_DR_CONNECTOR_GET_CLASS(drc);

        drck->attach(drc, dev, fdt, fdt_offset, !dev->hotplugged, errp);

        spapr_drc_attach(drc, dev, fdt, fdt_offset, !dev->hotplugged, errp);

        addr += SPAPR_MEMORY_BLOCK_SIZE;

        if (!dev->hotplugged) {

            sPAPRDRConnectorClass *drck = SPAPR_DR_CONNECTOR_GET_CLASS(drc);

            /* guests expect coldplugged LMBs to be pre-allocated */

            drck->set_allocation_state(drc, SPAPR_DR_ALLOCATION_STATE_USABLE);

            drck->set_isolation_state(drc, SPAPR_DR_ISOLATION_STATE_UNISOLATED);
@@ -2554,7 +2553,6 @@ static void spapr_add_lmbs(DeviceState *dev, uint64_t addr_start, uint64_t size, 
        if (dedicated_hp_event_source) {

            drc = spapr_drc_by_id(TYPE_SPAPR_DRC_LMB,

                                  addr_start / SPAPR_MEMORY_BLOCK_SIZE);

            drck = SPAPR_DR_CONNECTOR_GET_CLASS(drc);

            spapr_hotplug_req_add_by_count_indexed(SPAPR_DR_CONNECTOR_TYPE_LMB,

                                                   nr_lmbs,

                                                   spapr_drc_index(drc));
@@ -2742,7 +2740,6 @@ static void spapr_memory_unplug_request(HotplugHandler *hotplug_dev, 
    uint64_t addr_start, addr;

    int i;

    sPAPRDRConnector *drc;

    sPAPRDRConnectorClass *drck;

    sPAPRDIMMState *ds;



    addr_start = object_property_get_int(OBJECT(dimm), PC_DIMM_ADDR_PROP,
@@ -2762,14 +2759,12 @@ static void spapr_memory_unplug_request(HotplugHandler *hotplug_dev, 
                              addr / SPAPR_MEMORY_BLOCK_SIZE);

        g_assert(drc);



        drck = SPAPR_DR_CONNECTOR_GET_CLASS(drc);

        drck->detach(drc, dev, errp);

        spapr_drc_detach(drc, dev, errp);

        addr += SPAPR_MEMORY_BLOCK_SIZE;

    }



    drc = spapr_drc_by_id(TYPE_SPAPR_DRC_LMB,

                          addr_start / SPAPR_MEMORY_BLOCK_SIZE);

    drck = SPAPR_DR_CONNECTOR_GET_CLASS(drc);

    spapr_hotplug_req_remove_by_count_indexed(SPAPR_DR_CONNECTOR_TYPE_LMB,

                                              nr_lmbs, spapr_drc_index(drc));

out:
@@ -2824,7 +2819,6 @@ void spapr_core_unplug_request(HotplugHandler *hotplug_dev, DeviceState *dev, 
{

    int index;

    sPAPRDRConnector *drc;

    sPAPRDRConnectorClass *drck;

    Error *local_err = NULL;

    CPUCore *cc = CPU_CORE(dev);

    int smt = kvmppc_smt_threads();
@@ -2842,8 +2836,7 @@ void spapr_core_unplug_request(HotplugHandler *hotplug_dev, DeviceState *dev, 
    drc = spapr_drc_by_id(TYPE_SPAPR_DRC_CPU, index * smt);

    g_assert(drc);



    drck = SPAPR_DR_CONNECTOR_GET_CLASS(drc);

    drck->detach(drc, dev, &local_err);

    spapr_drc_detach(drc, dev, &local_err);

    if (local_err) {

        error_propagate(errp, local_err);

        return;
@@ -2887,8 +2880,8 @@ static void spapr_core_plug(HotplugHandler *hotplug_dev, DeviceState *dev, 
    }



    if (drc) {

        sPAPRDRConnectorClass *drck = SPAPR_DR_CONNECTOR_GET_CLASS(drc);

        drck->attach(drc, dev, fdt, fdt_offset, !dev->hotplugged, &local_err);

        spapr_drc_attach(drc, dev, fdt, fdt_offset, !dev->hotplugged,

                         &local_err);

        if (local_err) {

            g_free(fdt);

            error_propagate(errp, local_err);

hw/ppc/spapr_drc.c

+6 −12
Original line number Diff line number Diff line
@@ -49,8 +49,6 @@ uint32_t spapr_drc_index(sPAPRDRConnector *drc) 
static uint32_t set_isolation_state(sPAPRDRConnector *drc,

                                    sPAPRDRIsolationState state)

{

    sPAPRDRConnectorClass *drck = SPAPR_DR_CONNECTOR_GET_CLASS(drc);



    trace_spapr_drc_set_isolation_state(spapr_drc_index(drc), state);



    /* if the guest is configuring a device attached to this DRC, we
@@ -105,7 +103,7 @@ static uint32_t set_isolation_state(sPAPRDRConnector *drc, 
            uint32_t drc_index = spapr_drc_index(drc);

            if (drc->configured) {

                trace_spapr_drc_set_isolation_state_finalizing(drc_index);

                drck->detach(drc, DEVICE(drc->dev), NULL);

                spapr_drc_detach(drc, DEVICE(drc->dev), NULL);

            } else {

                trace_spapr_drc_set_isolation_state_deferring(drc_index);

            }
@@ -119,8 +117,6 @@ static uint32_t set_isolation_state(sPAPRDRConnector *drc, 
static uint32_t set_allocation_state(sPAPRDRConnector *drc,

                                     sPAPRDRAllocationState state)

{

    sPAPRDRConnectorClass *drck = SPAPR_DR_CONNECTOR_GET_CLASS(drc);



    trace_spapr_drc_set_allocation_state(spapr_drc_index(drc), state);



    if (state == SPAPR_DR_ALLOCATION_STATE_USABLE) {
@@ -151,7 +147,7 @@ static uint32_t set_allocation_state(sPAPRDRConnector *drc, 
            drc->allocation_state == SPAPR_DR_ALLOCATION_STATE_UNUSABLE) {

            uint32_t drc_index = spapr_drc_index(drc);

            trace_spapr_drc_set_allocation_state_finalizing(drc_index);

            drck->detach(drc, DEVICE(drc->dev), NULL);

            spapr_drc_detach(drc, DEVICE(drc->dev), NULL);

        } else if (drc->allocation_state == SPAPR_DR_ALLOCATION_STATE_USABLE) {

            drc->awaiting_allocation = false;

        }
@@ -289,7 +285,7 @@ static void prop_get_fdt(Object *obj, Visitor *v, const char *name, 
    } while (fdt_depth != 0);

}



static void attach(sPAPRDRConnector *drc, DeviceState *d, void *fdt,

void spapr_drc_attach(sPAPRDRConnector *drc, DeviceState *d, void *fdt,

                      int fdt_start_offset, bool coldplug, Error **errp)

{

    trace_spapr_drc_attach(spapr_drc_index(drc));
@@ -341,7 +337,7 @@ static void attach(sPAPRDRConnector *drc, DeviceState *d, void *fdt, 
                             NULL, 0, NULL);

}



static void detach(sPAPRDRConnector *drc, DeviceState *d, Error **errp)

void spapr_drc_detach(sPAPRDRConnector *drc, DeviceState *d, Error **errp)

{

    trace_spapr_drc_detach(spapr_drc_index(drc));
@@ -444,7 +440,7 @@ static void reset(DeviceState *d) 
         * force removal if we are

         */

        if (drc->awaiting_release) {

            drck->detach(drc, DEVICE(drc->dev), NULL);

            spapr_drc_detach(drc, DEVICE(drc->dev), NULL);

        }



        /* non-PCI devices may be awaiting a transition to UNUSABLE */
@@ -641,8 +637,6 @@ static void spapr_dr_connector_class_init(ObjectClass *k, void *data) 
    drck->set_isolation_state = set_isolation_state;

    drck->set_allocation_state = set_allocation_state;

    drck->get_name = get_name;

    drck->attach = attach;

    drck->detach = detach;

    drck->release_pending = release_pending;

    drck->set_signalled = set_signalled;

    /*

hw/ppc/spapr_pci.c

+3 −6
Original line number Diff line number Diff line
@@ -1349,7 +1349,6 @@ static void spapr_phb_add_pci_device(sPAPRDRConnector *drc, 
                                     PCIDevice *pdev,

                                     Error **errp)

{

    sPAPRDRConnectorClass *drck = SPAPR_DR_CONNECTOR_GET_CLASS(drc);

    DeviceState *dev = DEVICE(pdev);

    void *fdt = NULL;

    int fdt_start_offset = 0, fdt_size;
@@ -1361,7 +1360,7 @@ static void spapr_phb_add_pci_device(sPAPRDRConnector *drc, 
        goto out;

    }



    drck->attach(drc, DEVICE(pdev),

    spapr_drc_attach(drc, DEVICE(pdev),

                     fdt, fdt_start_offset, !dev->hotplugged, errp);

out:

    if (*errp) {
@@ -1391,9 +1390,7 @@ static void spapr_phb_remove_pci_device(sPAPRDRConnector *drc, 
                                        PCIDevice *pdev,

                                        Error **errp)

{

    sPAPRDRConnectorClass *drck = SPAPR_DR_CONNECTOR_GET_CLASS(drc);



    drck->detach(drc, DEVICE(pdev), errp);

    spapr_drc_detach(drc, DEVICE(pdev), errp);

}



static sPAPRDRConnector *spapr_phb_get_pci_func_drc(sPAPRPHBState *phb,

include/hw/ppc/spapr_drc.h

+4 −3
Original line number Diff line number Diff line
@@ -226,9 +226,6 @@ typedef struct sPAPRDRConnectorClass { 
    const char *(*get_name)(sPAPRDRConnector *drc);



    /* QEMU interfaces for managing hotplug operations */

    void (*attach)(sPAPRDRConnector *drc, DeviceState *d, void *fdt,

                   int fdt_start_offset, bool coldplug, Error **errp);

    void (*detach)(sPAPRDRConnector *drc, DeviceState *d, Error **errp);

    bool (*release_pending)(sPAPRDRConnector *drc);

    void (*set_signalled)(sPAPRDRConnector *drc);

} sPAPRDRConnectorClass;
@@ -243,4 +240,8 @@ sPAPRDRConnector *spapr_drc_by_id(const char *type, uint32_t id); 
int spapr_drc_populate_dt(void *fdt, int fdt_offset, Object *owner,

                          uint32_t drc_type_mask);



void spapr_drc_attach(sPAPRDRConnector *drc, DeviceState *d, void *fdt,

                      int fdt_start_offset, bool coldplug, Error **errp);

void spapr_drc_detach(sPAPRDRConnector *drc, DeviceState *d, Error **errp);



#endif /* HW_SPAPR_DRC_H */