Commit 0a75b60c authored by Mark Kanda's avatar Mark Kanda Committed by Stefan Hajnoczi
Browse files

virtio-blk: reject configs with logical block size > physical block size 



virtio-blk logical block size should never be larger than physical block
size because it doesn't make sense to have such configurations. QEMU doesn't
have a way to effectively express this condition; the best it can do is
report the physical block exponent as 0 - indicating the logical block size
equals the physical block size.

This is identical to commit 3da023b5
but applied to virtio-blk (instead of virtio-scsi).

Signed-off-by: default avatarMark Kanda <mark.kanda@oracle.com>
Reviewed-by: default avatarKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: default avatarAmeya More <ameya.more@oracle.com>
Reviewed-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Message-id: 773169891f9f2deb4cb7c4ef2655580dbe24c1d1.1513005190.git.mark.kanda@oracle.com
Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
parent 6040aedd

hw/block/virtio-blk.c

+7 −0
Original line number Diff line number Diff line
@@ -949,6 +949,13 @@ static void virtio_blk_device_realize(DeviceState *dev, Error **errp) 


    blkconf_blocksizes(&conf->conf);



    if (conf->conf.logical_block_size >

        conf->conf.physical_block_size) {

        error_setg(errp,

                   "logical_block_size > physical_block_size not supported");

        return;

    }



    virtio_init(vdev, "virtio-blk", VIRTIO_ID_BLOCK,

                sizeof(struct virtio_blk_config));