Commit 0a417869 authored by Bharata B Rao's avatar Bharata B Rao Committed by David Gibson
Browse files

spapr: Move memory hotplug to RTAS_LOG_V6_HP_ID_DRC_COUNT type 



Till now memory hotplug used RTAS_LOG_V6_HP_ID_DRC_INDEX hotplug type
which meant that we generated one hotplug type of EPOW event for every
256MB (SPAPR_MEMORY_BLOCK_SIZE). This quickly overruns the kernel
rtas log buffer thus resulting in loss of memory hotplug events. Switch
to RTAS_LOG_V6_HP_ID_DRC_COUNT hotplug type for memory so that we
generate only one event per hotplug request.

Signed-off-by: default avatarBharata B Rao <bharata@linux.vnet.ibm.com>
Reviewed-by: default avatarMichael Roth <mdroth@linux.vnet.ibm.com>
Reviewed-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent 7a36ae7a

hw/ppc/spapr.c

+1 −1
Original line number Diff line number Diff line
@@ -2062,9 +2062,9 @@ static void spapr_add_lmbs(DeviceState *dev, uint64_t addr, uint64_t size, 


        drck = SPAPR_DR_CONNECTOR_GET_CLASS(drc);

        drck->attach(drc, dev, fdt, fdt_offset, !dev->hotplugged, errp);

        spapr_hotplug_req_add_by_index(drc);

        addr += SPAPR_MEMORY_BLOCK_SIZE;

    }

    spapr_hotplug_req_add_by_count(SPAPR_DR_CONNECTOR_TYPE_LMB, nr_lmbs);

}



static void spapr_memory_plug(HotplugHandler *hotplug_dev, DeviceState *dev,