Commit 0a2923f8 authored by Aurelien Jarno's avatar Aurelien Jarno
Browse files

tcg/mips: fix store softmmu slow path 



Commit 9d8bf2d1 moved the softmmu slow path out of line and introduce a
regression at the same time by always calling tcg_out_tlb_load with
is_load=1. This makes impossible to run any significant code under
qemu-system-mips*.

Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-stable@nongnu.org
Reviewed-by: default avatarRichard Henderson <rth@twiddle.net>
Signed-off-by: default avatarAurelien Jarno <aurelien@aurel32.net>
parent ee29498e

tcg/mips/tcg-target.c

+1 −1
Original line number Diff line number Diff line
@@ -1302,7 +1302,7 @@ static void tcg_out_qemu_st(TCGContext *s, const TCGArg *args, bool is_64) 
       so we can reuse that for the base.  */

    base = (TARGET_LONG_BITS == 32 ? TCG_REG_A1 : TCG_REG_A2);

    tcg_out_tlb_load(s, base, addr_regl, addr_regh, mem_index,

                     s_bits, label_ptr, 1);

                     s_bits, label_ptr, 0);

    tcg_out_qemu_st_direct(s, data_regl, data_regh, base, opc);

    add_qemu_ldst_label(s, 0, opc, data_regl, data_regh, addr_regl, addr_regh,

                        mem_index, s->code_ptr, label_ptr);