Commit 097a97a6 authored by Kirill Batuzov's avatar Kirill Batuzov Committed by Michael S. Tsirkin
Browse files

acpi-build: properly decrement objects' reference counters 



Object returned by object_property_get_qobject needs its reference counter to
be decremented when it is not needed by caller anymore.

Signed-off-by: default avatarKirill Batuzov <batuzovk@ispras.ru>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 7c38ecd0

hw/i386/acpi-build.c

+6 −0
Original line number Diff line number Diff line
@@ -156,18 +156,21 @@ static void acpi_get_pm_info(AcpiPmInfo *pm) 
    } else {

        pm->s3_disabled = false;

    }

    qobject_decref(o);

    o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_DISABLED, NULL);

    if (o) {

        pm->s4_disabled = qint_get_int(qobject_to_qint(o));

    } else {

        pm->s4_disabled = false;

    }

    qobject_decref(o);

    o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_VAL, NULL);

    if (o) {

        pm->s4_val = qint_get_int(qobject_to_qint(o));

    } else {

        pm->s4_val = false;

    }

    qobject_decref(o);



    /* Fill in mandatory properties */

    pm->sci_int = object_property_get_int(obj, ACPI_PM_PROP_SCI_INT, NULL);
@@ -973,6 +976,7 @@ static void build_pci_bus_end(PCIBus *bus, void *bus_state) 
        }

    }



    qobject_decref(bsel);

    build_free_array(bus_table);

    build_pci_bus_state_cleanup(child);

    g_free(child);
@@ -1362,10 +1366,12 @@ static bool acpi_get_mcfg(AcpiMcfgInfo *mcfg) 
        return false;

    }

    mcfg->mcfg_base = qint_get_int(qobject_to_qint(o));

    qobject_decref(o);



    o = object_property_get_qobject(pci_host, PCIE_HOST_MCFG_SIZE, NULL);

    assert(o);

    mcfg->mcfg_size = qint_get_int(qobject_to_qint(o));

    qobject_decref(o);

    return true;

}