Commit 08f00df4 authored by Laurent Vivier's avatar Laurent Vivier Committed by Markus Armbruster
Browse files

qdev: remove cannot_destroy_with_object_finalize_yet 



As all users have been removed, we can remove
cannot_destroy_with_object_finalize_yet field
from the DeviceClass structure.

Signed-off-by: default avatarLaurent Vivier <lvivier@redhat.com>
Message-Id: <20170414083717.13641-5-lvivier@redhat.com>
Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
Acked-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
parent d28fca15

include/hw/qdev-core.h

+0 −13
Original line number Diff line number Diff line
@@ -113,19 +113,6 @@ typedef struct DeviceClass { 
     * TODO remove once we're there

     */

    bool cannot_instantiate_with_device_add_yet;

    /*

     * Does this device model survive object_unref(object_new(TNAME))?

     * All device models should, and this flag shouldn't exist.  Some

     * devices crash in object_new(), some crash or hang in

     * object_unref().  Makes introspecting properties with

     * qmp_device_list_properties() dangerous.  Bad, because it's used

     * by -device FOO,help.  This flag serves to protect that code.

     * It should never be set without a comment explaining why it is

     * set.

     * TODO remove once we're there

     */

    bool cannot_destroy_with_object_finalize_yet;



    bool hotpluggable;



    /* callbacks */

qmp.c

+0 −5
Original line number Diff line number Diff line
@@ -548,11 +548,6 @@ DevicePropertyInfoList *qmp_device_list_properties(const char *typename, 
        return NULL;

    }



    if (DEVICE_CLASS(klass)->cannot_destroy_with_object_finalize_yet) {

        error_setg(errp, "Can't list properties of device '%s'", typename);

        return NULL;

    }



    obj = object_new(typename);



    object_property_iter_init(&iter, obj);