Commit 07b026fd authored by Li Qiang's avatar Li Qiang Committed by Stefan Hajnoczi
Browse files

usbredir: free vm_change_state_handler in usbredir destroy dispatch 



In usbredir destroy dispatch function, it doesn't free the vm change
state handler once registered in usbredir_realize function. This will
lead a memory leak issue. This patch avoid this.

Signed-off-by: default avatarLi Qiang <liqiang6-s@360.cn>
Reviewed-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 58216976.d0236b0a.77b99.bcd6@mx.google.com
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent 791f9775

hw/usb/redirect.c

+4 −1
Original line number Diff line number Diff line
@@ -132,6 +132,7 @@ struct USBRedirDevice { 
    struct usbredirfilter_rule *filter_rules;

    int filter_rules_count;

    int compatible_speedmask;

    VMChangeStateEntry *vmstate;

};



#define TYPE_USB_REDIR "usb-redir"
@@ -1411,6 +1412,7 @@ static void usbredir_realize(USBDevice *udev, Error **errp) 
                             usbredir_chardev_read, usbredir_chardev_event,

                             dev, NULL, true);



    dev->vmstate =

        qemu_add_vm_change_state_handler(usbredir_vm_state_change, dev);

}
@@ -1450,6 +1452,7 @@ static void usbredir_handle_destroy(USBDevice *udev) 
    }



    free(dev->filter_rules);

    qemu_del_vm_change_state_handler(dev->vmstate);

}



static int usbredir_check_filter(USBRedirDevice *dev)