Commit 0794d889 authored by Amit Shah's avatar Amit Shah
Browse files

vmstate-static-checker: fix size mismatch detection in unused fields 

If a field changed from something to unused, the checker wasn't flagging
if the field size mismatched.  This was noticed in:

http://thread.gmane.org/gmane.comp.emulators.qemu/419802



where the 4->1 size change along with field name change to 'unused'
wasn't being flagged.  Fix this.

Signed-off-by: default avatarAmit Shah <amit.shah@redhat.com>
Message-Id: <d7ec03a9b2edfa0616764887a51ba8f64fdd3f68.1466165736.git.amit.shah@redhat.com>
Signed-off-by: default avatarAmit Shah <amit.shah@redhat.com>
parent 0d9f9a5c

scripts/vmstate-static-checker.py

+1 −1
Original line number Diff line number Diff line
@@ -185,7 +185,7 @@ def check_fields(src_fields, dest_fields, desc, sec): 
            if unused_count == 0:

                advance_dest = True



        if unused_count > 0:

        if unused_count != 0:

            if advance_dest == False:

                unused_count = unused_count - s_item["size"]

                if unused_count == 0: