Commit 056b9775 authored by Nikunj A Dadhania's avatar Nikunj A Dadhania Committed by David Gibson
Browse files

ppc/xics: account correct irq status 



Fix inconsistent irq status, because of this in the trace logs, for e.g.
LSI status was 0x7, i.e. XICS_STATUS_ASSERTED, XICS_STATUS_SENT and
XICS_STATUS_REJECTED all set, which did not make sense. So the REJECTED
would have been set in earlier interrupt cycle, and then asserted and
sent in this current one.

Signed-off-by: default avatarNikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent 5145ad4f

hw/intc/xics.c

+5 −2
Original line number Diff line number Diff line
@@ -505,8 +505,11 @@ static void ics_reject(ICSState *ics, int nr) 
    ICSIRQState *irq = ics->irqs + nr - ics->offset;



    trace_xics_ics_reject(nr, nr - ics->offset);

    irq->status |= XICS_STATUS_REJECTED; /* Irrelevant but harmless for LSI */

    irq->status &= ~XICS_STATUS_SENT; /* Irrelevant but harmless for MSI */

    if (irq->flags & XICS_FLAGS_IRQ_MSI) {

        irq->status |= XICS_STATUS_REJECTED;

    } else if (irq->flags & XICS_FLAGS_IRQ_LSI) {

        irq->status &= ~XICS_STATUS_SENT;

    }

}



static void ics_resend(ICSState *ics)