Commit 03f28efb authored by Greg Kurz's avatar Greg Kurz Committed by Eduardo Habkost
Browse files

vl: exit if a bad property value is passed to -global 



When passing '-global driver=host-powerpc64-cpu,property=compat,value=foo'
on the command line, without this patch, we get the following warning per
device (which means many lines if the guests has many cpus):

qemu-system-ppc64: Warning: can't apply global host-powerpc64-cpu.compat=foo:
    Invalid compatibility mode "foo"

... and QEMU continues execution, ignoring the property.

With this patch, we get a single line:

qemu-system-ppc64: can't apply global host-powerpc64-cpu.compat=foo:
    Invalid compatibility mode "foo"

... and QEMU exits.

The previous behavior is kept for hotplugged devices since we don't want
QEMU to exit when doing device_add.

Reviewed-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
Signed-off-by: default avatarGreg Kurz <groug@kaod.org>
Reviewed-by: default avatarEduardo Habkost <ehabkost@redhat.com>
Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
parent b3443f43

vl.c

+1 −0
Original line number Diff line number Diff line
@@ -2922,6 +2922,7 @@ static int global_init_func(void *opaque, QemuOpts *opts, Error **errp) 
    g->property = qemu_opt_get(opts, "property");

    g->value    = qemu_opt_get(opts, "value");

    g->user_provided = true;

    g->errp = &error_fatal;

    qdev_prop_register_global(g);

    return 0;

}