Commit 03a96b83 authored by Thomas Huth's avatar Thomas Huth Committed by Paolo Bonzini
Browse files

kvm: Silence warning from valgrind 



valgrind complains here about uninitialized bytes with the following message:

==17814== Syscall param ioctl(generic) points to uninitialised byte(s)
==17814==    at 0x466A780: ioctl (in /usr/lib64/power8/libc-2.17.so)
==17814==    by 0x100735B7: kvm_vm_ioctl (kvm-all.c:1920)
==17814==    by 0x10074583: kvm_set_ioeventfd_mmio (kvm-all.c:574)

Let's fix it by using a proper struct initializer in kvm_set_ioeventfd_mmio().

Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
Message-Id: <1430153944-24368-1-git-send-email-thuth@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 49814752

kvm-all.c

+7 −7
Original line number Diff line number Diff line
@@ -552,13 +552,13 @@ static int kvm_set_ioeventfd_mmio(int fd, hwaddr addr, uint32_t val, 
                                  bool assign, uint32_t size, bool datamatch)

{

    int ret;

    struct kvm_ioeventfd iofd;



    iofd.datamatch = datamatch ? adjust_ioeventfd_endianness(val, size) : 0;

    iofd.addr = addr;

    iofd.len = size;

    iofd.flags = 0;

    iofd.fd = fd;

    struct kvm_ioeventfd iofd = {

        .datamatch = datamatch ? adjust_ioeventfd_endianness(val, size) : 0,

        .addr = addr,

        .len = size,

        .flags = 0,

        .fd = fd,

    };



    if (!kvm_enabled()) {

        return -ENOSYS;