Commit 039d4e3d authored by John Snow's avatar John Snow Committed by Peter Maydell
Browse files

scsi: Address spurious clang warning 

Some versions of Clang prior to 6.0 (and some builds of clang after,
such as 6.0.1-2.fc28) fail to recognize { 0 } as a valid initializer
for a struct with subobjects when -Wmissing-braces is enabled.

https://bugs.llvm.org/show_bug.cgi?id=21689 and
https://reviews.llvm.org/rL314499

 suggests this should be fixed in 6.0,
but it might not be the case for older versions or downstream versions.

For now, follow the precedent of ebf2a499 and replace the standard { 0 }
with the accepted { } to silence this warning and allow the build to
work under clang 6.0.1-2.fc28, and builds prior to 6.0.

Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Message-id: 20181127184929.20065-1-jsnow@redhat.com
Reviewed-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
parent 549b50a3

scsi/qemu-pr-helper.c

+1 −1
Original line number Diff line number Diff line
@@ -236,7 +236,7 @@ static void dm_init(void) 
        perror("Cannot open " CONTROL_PATH);

        exit(1);

    }

    struct dm_ioctl dm = { 0 };

    struct dm_ioctl dm = { };

    if (!dm_ioctl(DM_VERSION, &dm)) {

        perror("ioctl");

        exit(1);