Commit 02a4d82e authored by Yuri Pudgorodskiy's avatar Yuri Pudgorodskiy Committed by Michael Roth
Browse files

qga: fix for default env processing for guest-exec 



envp == NULL must be passed inside gspawn() if it was not passed with
the command line. Original code inherits environment from the QGA,
which is wrong.

Signed-off-by: default avatarYuri Pudgorodskiy <yur@virtuozzo.com>
Signed-off-by: default avatarDenis V. Lunev <den@openvz.org>
CC: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: default avatarMichael Roth <mdroth@linux.vnet.ibm.com>
parent c27e9014

qga/commands.c

+1 −1
Original line number Diff line number Diff line
@@ -398,7 +398,7 @@ GuestExec *qmp_guest_exec(const char *path, 
    arglist.next = has_arg ? arg : NULL;



    argv = guest_exec_get_args(&arglist, true);

    envp = guest_exec_get_args(has_env ? env : NULL, false);

    envp = has_env ? guest_exec_get_args(env, false) : NULL;



    flags = G_SPAWN_SEARCH_PATH | G_SPAWN_DO_NOT_REAP_CHILD;

    if (!has_output) {