Commit 029afc4e authored by Markus Armbruster's avatar Markus Armbruster
Browse files

qdev: Fix device_add DRIVER,help to print to monitor 



Help on device properties gets printed to stdout instead of the
monitor.  If you have the monitor anywhere else, no help for you.
Broken when commit e1043d67 "qdev: use object_property_help()"
accidentally switched from qemu_printf() to printf().  Switch right
back.

Fixes: e1043d67
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Message-Id: <20200714160202.3121879-2-armbru@redhat.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: default avatarLi Qiang <liq3ea@gmail.com>
Reviewed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
parent af3d6905

qdev-monitor.c

+1 −1
Original line number Diff line number Diff line
@@ -300,7 +300,7 @@ int qdev_device_help(QemuOpts *opts) 
    }

    g_ptr_array_sort(array, (GCompareFunc)qemu_pstrcmp0);

    for (i = 0; i < array->len; i++) {

        printf("%s\n", (char *)array->pdata[i]);

        qemu_printf("%s\n", (char *)array->pdata[i]);

    }

    g_ptr_array_set_free_func(array, g_free);

    g_ptr_array_free(array, true);