Commit 023c3a97 authored by Paolo Bonzini's avatar Paolo Bonzini
Browse files

serial: update LSR on enabling/disabling FIFOs 



When the transmit FIFO is emptied or enabled, the transmitter
hold register is empty.  When it is disabled, it is also emptied and
in addition the previous contents of the transmitter hold register
are discarded.  In either case, the THRE bit in LSR must be set and
THRI raised.

When the receive FIFO is emptied or enabled, the data ready and break
bits must be cleared in LSR.  Likewise when the receive FIFO is disabled.

Reviewed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 0d931d70

hw/char/serial.c

+3 −0
Original line number Diff line number Diff line
@@ -377,12 +377,15 @@ static void serial_ioport_write(void *opaque, hwaddr addr, uint64_t val, 
        /* FIFO clear */



        if (val & UART_FCR_RFR) {

            s->lsr &= ~(UART_LSR_DR | UART_LSR_BI);

            timer_del(s->fifo_timeout_timer);

            s->timeout_ipending = 0;

            fifo8_reset(&s->recv_fifo);

        }



        if (val & UART_FCR_XFR) {

            s->lsr |= UART_LSR_THRE;

            s->thr_ipending = 1;

            fifo8_reset(&s->xmit_fifo);

        }