Commit 01dd96d8 authored Aug 21, 2013 by Laszlo Ersek Committed by Kevin Wolf Aug 30, 2013

raw_bsd: introduce "special members"



On 08/05/13 15:03, Paolo Bonzini wrote:
>
> [...]
>
> 3) These members are special
>
>     .format_name   is the string "raw"
>     .bdrv_open     raw_open should set bs->sg to bs->file->sg and return 0
>     .bdrv_close    raw_close should do nothing
>     .bdrv_probe    raw_probe should just return 1.

v1->v2:

On 08/20/13 10:11, Kevin Wolf wrote:
> Am 16.08.2013 um 16:15 hat Laszlo Ersek geschrieben:

>> +static int raw_probe(void)
>> +{
>> +    return 1;
>> +}
>
> Maybe add a comment here like "smallest possible positive score so that
> raw is used if and only if no other block driver works".

Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>

parent 1565262c

block/raw_bsd.c

+23 −0

Original line number	Diff line number	Diff line
		@@ -112,3 +112,26 @@ static TYPE raw_create(void)
		{
		return bdrv_create_file();
		}

		static const char *raw_format_name(void)
		{
		return "raw";
		}

		static int raw_open(BlockDriverState *bs)
		{
		bs->sg = bs->file->sg;
		return 0;
		}

		static void raw_close(void)
		{
		}

		static int raw_probe(void)
		{
		/* smallest possible positive score so that raw is used if and only if no
		* other block driver works
		*/
		return 1;
		}