Commit 01a72012 authored by Peter Maydell's avatar Peter Maydell
Browse files

target-sh4: Use glib allocator in movcal helper 



Coverity spots that helper_movcal() calls malloc() but doesn't
check for failure. Fix this by switching to the glib allocation
functions, which abort on allocation failure.

Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Message-id: 1468327859-21385-1-git-send-email-peter.maydell@linaro.org
Acked-by: default avatarAurelien Jarno <aurelien@aurel32.net>
parent e3643d32

target-sh4/op_helper.c

+4 −3
Original line number Diff line number Diff line
@@ -109,7 +109,8 @@ void helper_movcal(CPUSH4State *env, uint32_t address, uint32_t value) 
{

    if (cpu_sh4_is_cached (env, address))

    {

	memory_content *r = malloc (sizeof(memory_content));

        memory_content *r = g_new(memory_content, 1);



	r->address = address;

	r->value = value;

	r->next = NULL;
@@ -126,7 +127,7 @@ void helper_discard_movcal_backup(CPUSH4State *env) 
    while(current)

    {

	memory_content *next = current->next;

	free (current);

        g_free(current);

	env->movcal_backup = current = next;

	if (current == NULL)

	    env->movcal_backup_tail = &(env->movcal_backup);
@@ -149,7 +150,7 @@ void helper_ocbi(CPUSH4State *env, uint32_t address) 
		env->movcal_backup_tail = current;

	    }



	    free (*current);

            g_free(*current);

	    *current = next;

	    break;

	}