Commit e819c967 authored by 余昆's avatar 余昆
Browse files

23 Add unittest to improve code coverage 


Former-commit-id: 5d5629da7cad9503816f63917425bcde3c5b6a90
parent e7dd603d

CHANGELOG.md

+1 −0
Original line number Diff line number Diff line
@@ -190,6 +190,7 @@ Please mark all change in change log and use the ticket from JIRA. 
- MS-570 - Add prometheus docker-compose file

- MS-576 - Scheduler refactor

- MS-592 - Change showtables stream transport to unary

#23 Add unittest to improve code coverage



## New Feature

- MS-343 - Implement ResourceMgr

core/src/scheduler/optimizer/LargeSQ8HPass.cpp

+56 −56
Original line number Diff line number Diff line
@@ -15,19 +15,19 @@ 
// specific language governing permissions and limitations

// under the License.



//#include "scheduler/optimizer/LargeSQ8HPass.h"

//#include "cache/GpuCacheMgr.h"

//#include "scheduler/SchedInst.h"

//#include "scheduler/Utils.h"

//#include "scheduler/task/SearchTask.h"

//#include "scheduler/tasklabel/SpecResLabel.h"

//#include "utils/Log.h"

//

//namespace milvus {

//namespace scheduler {

//

//bool

//LargeSQ8HPass::Run(const TaskPtr& task) {

#include "scheduler/optimizer/LargeSQ8HPass.h"

#include "cache/GpuCacheMgr.h"

#include "scheduler/SchedInst.h"

#include "scheduler/Utils.h"

#include "scheduler/task/SearchTask.h"

#include "scheduler/tasklabel/SpecResLabel.h"

#include "utils/Log.h"



namespace milvus {

namespace scheduler {



bool

LargeSQ8HPass::Run(const TaskPtr& task) {

    //    if (task->Type() != TaskType::SearchTask) {

    //        return false;

    //    }
@@ -67,7 +67,7 @@ 
    //    task->label() = label;

    //

    //    return true;

//}

//

//}  // namespace scheduler

//}  // namespace milvus
 
}



}  // namespace scheduler

}  // namespace milvus

core/src/scheduler/optimizer/LargeSQ8HPass.h

+31 −31
Original line number Diff line number Diff line
@@ -14,34 +14,34 @@ 
// KIND, either express or implied.  See the License for the

// specific language governing permissions and limitations

// under the License.

//#pragma once

//

//#include <condition_variable>

//#include <deque>

//#include <list>

//#include <memory>

//#include <mutex>

//#include <queue>

//#include <string>

//#include <thread>

//#include <unordered_map>

//#include <vector>

//

//#include "Pass.h"

//

//namespace milvus {

//namespace scheduler {

//

//class LargeSQ8HPass : public Pass {

// public:

//    LargeSQ8HPass() = default;

//

// public:

//    bool

//    Run(const TaskPtr& task) override;

//};

//

//using LargeSQ8HPassPtr = std::shared_ptr<LargeSQ8HPass>;

//

//}  // namespace scheduler

//}  // namespace milvus
 
#pragma once



#include <condition_variable>

#include <deque>

#include <list>

#include <memory>

#include <mutex>

#include <queue>

#include <string>

#include <thread>

#include <unordered_map>

#include <vector>



#include "Pass.h"



namespace milvus {

namespace scheduler {



class LargeSQ8HPass : public Pass {

 public:

    LargeSQ8HPass() = default;



 public:

    bool

    Run(const TaskPtr& task) override;

};



using LargeSQ8HPassPtr = std::shared_ptr<LargeSQ8HPass>;



}  // namespace scheduler

}  // namespace milvus

core/src/scheduler/optimizer/Optimizer.cpp

+6 −6
Original line number Diff line number Diff line
@@ -20,12 +20,12 @@ 
namespace milvus {

namespace scheduler {



//void

//Optimizer::Init() {

void

Optimizer::Init() {

    //    for (auto& pass : pass_list_) {

    //        pass->Init();

    //    }

//}

}



bool

Optimizer::Run(const TaskPtr& task) {

core/src/scheduler/optimizer/Optimizer.h

+2 −2
Original line number Diff line number Diff line
@@ -38,8 +38,8 @@ class Optimizer { 
    explicit Optimizer(std::vector<PassPtr> pass_list) : pass_list_(std::move(pass_list)) {

    }



//    void

//    Init();

    void

    Init();



    bool

    Run(const TaskPtr& task);