Commit dbfd2789 authored by groot's avatar groot
Browse files

#48 Config unittest failed 


Former-commit-id: 8db0978e20337e2faaf989ec932955b1330d58dc
parent 355d4a08

CHANGELOG.md

+2 −1
Original line number Diff line number Diff line
@@ -26,13 +26,14 @@ Please mark all change in change log and use the ticket from JIRA. 
- MS-653 - When config check fail, Milvus close without message

- MS-654 - Describe index timeout when building index

- MS-658 - Fix SQ8 Hybrid can't search

- \#9 Change default gpu_cache_capacity to 4

- MS-665 - IVF_SQ8H search crash when no GPU resource in search_resources

- \#9 - Change default gpu_cache_capacity to 4

- \#20 - C++ sdk example get grpc error 

- \#23 - Add unittest to improve code coverage

- \#31 - make clang-format failed after run build.sh -l

- \#39 - Create SQ8H index hang if using github server version

- \#30 - Some troubleshoot messages in Milvus do not provide enough information

- \#48 - Config unittest failed



## Improvement

- MS-552 - Add and change the easylogging library

core/unittest/server/utils.cpp

+42 −43
Original line number Diff line number Diff line
@@ -42,7 +42,6 @@ static const char *VALID_CONFIG_STR = "# Default values are used when you make n 
                                      "\n"

                                      "  insert_buffer_size: 4             # GB, maximum insert buffer size allowed\n"

                                      "                                    # sum of insert_buffer_size and cpu_cache_capacity cannot exceed total memory\n"

                                            "  build_index_gpu: 0                # gpu id used for building index\n"

                                      "\n"

                                      "  preload_table:                    # preload data at startup, '*' means load all tables, empty value means no preload\n"

                                      "                                    # you can specify preload tables like this: table1,table2,table3\n"
@@ -65,9 +64,9 @@ static const char *VALID_CONFIG_STR = "# Default values are used when you make n 
                                      "                                    # if nq >= use_blas_threshold, use OpenBlas, slower with stable response times\n"

                                      "\n"

                                      "resource_config:\n"

                                            "  resource_pool:\n"

                                            "    - cpu\n"

                                            "    - gpu0";

                                      "  search_resources:                 # define the GPUs used for search computation, valid value: gpux\n"

                                      "    - gpu0\n"

                                      "  index_build_device: gpu0          # GPU used for building index";



static const char *INVALID_CONFIG_STR = "*INVALID*";