Commit d09a8e8d authored by peng.xu's avatar peng.xu
Browse files

Merge branch 'branch-0.5.0' into 'branch-0.5.0' 

refine code

See merge request megasearch/milvus!671

Former-commit-id: 0afbcf0ae13182f5b2d5de9d3eef13eb2c6ddabd
parents 547c5fa9 5ab6541c

cpp/README.md

+14 −6
Original line number Diff line number Diff line
@@ -105,13 +105,20 @@ please reinstall CMake with curl: 
   ```



##### code format and linting



Install clang-format and clang-tidy

```shell

CentOS 7:   

$ yum install clang

Ubuntu 16.04 or 18.04: 

$ sudo apt-get install clang-format clang-tidy

    

Ubuntu 16.04: 

$ sudo apt-get install clang-tidy

$ wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add -

$ sudo apt-add-repository "deb http://apt.llvm.org/xenial/ llvm-toolchain-xenial-6.0 main"

$ sudo apt-get update

$ sudo apt-get install clang-format-6.0

Ubuntu 18.04: 

$ sudo apt-get install clang-tidy clang-format

```  

```shell

$ ./build.sh -l

```
@@ -122,13 +129,14 @@ $ ./build.sh -u 
```



##### Run code coverage



Install lcov

```shell

CentOS 7:   

$ yum install lcov

Ubuntu 16.04 or 18.04: 

$ sudo apt-get install lcov

    

``` 

```shell  

$ ./build.sh -u -c

```

cpp/src/db/DBImpl.cpp

+2 −1
Original line number Diff line number Diff line
@@ -296,7 +296,8 @@ DBImpl::CreateIndex(const std::string& table_id, const TableIndex& index) { 
    std::vector<int> file_types;

    if (index.engine_type_ == static_cast<int32_t>(EngineType::FAISS_IDMAP)) {

        file_types = {

            static_cast<int32_t>(meta::TableFileSchema::NEW), static_cast<int32_t>(meta::TableFileSchema::NEW_MERGE),

            static_cast<int32_t>(meta::TableFileSchema::NEW),

            static_cast<int32_t>(meta::TableFileSchema::NEW_MERGE),

        };

    } else {

        file_types = {

cpp/src/db/insert/MemTableFile.cpp

+3 −3
Original line number Diff line number Diff line
@@ -55,9 +55,9 @@ MemTableFile::CreateTableFile() { 
Status

MemTableFile::Add(const VectorSourcePtr& source, IDNumbers& vector_ids) {

    if (table_file_schema_.dimension_ <= 0) {

        std::string err_msg = "MemTableFile::Add: table_file_schema dimension = " +

                              std::to_string(table_file_schema_.dimension_) + ", table_id = " +

                              table_file_schema_.table_id_;

        std::string err_msg =

            "MemTableFile::Add: table_file_schema dimension = " + std::to_string(table_file_schema_.dimension_) +

            ", table_id = " + table_file_schema_.table_id_;

        ENGINE_LOG_ERROR << err_msg;

        return Status(DB_ERROR, "Not able to create table file");

    }

cpp/src/db/meta/MySQLMetaImpl.cpp

+12 −9
Original line number Diff line number Diff line
@@ -148,14 +148,17 @@ static const MetaSchema TABLES_SCHEMA(META_TABLES, { 
                                                   });



// TableFiles schema

static const MetaSchema TABLEFILES_SCHEMA(

    META_TABLEFILES,

    {

        MetaField("id", "BIGINT", "PRIMARY KEY AUTO_INCREMENT"), MetaField("table_id", "VARCHAR(255)", "NOT NULL"),

        MetaField("engine_type", "INT", "DEFAULT 1 NOT NULL"), MetaField("file_id", "VARCHAR(255)", "NOT NULL"),

        MetaField("file_type", "INT", "DEFAULT 0 NOT NULL"), MetaField("file_size", "BIGINT", "DEFAULT 0 NOT NULL"),

        MetaField("row_count", "BIGINT", "DEFAULT 0 NOT NULL"), MetaField("updated_time", "BIGINT", "NOT NULL"),

        MetaField("created_on", "BIGINT", "NOT NULL"), MetaField("date", "INT", "DEFAULT -1 NOT NULL"),

static const MetaSchema TABLEFILES_SCHEMA(META_TABLEFILES, {

                                                               MetaField("id", "BIGINT", "PRIMARY KEY AUTO_INCREMENT"),

                                                               MetaField("table_id", "VARCHAR(255)", "NOT NULL"),

                                                               MetaField("engine_type", "INT", "DEFAULT 1 NOT NULL"),

                                                               MetaField("file_id", "VARCHAR(255)", "NOT NULL"),

                                                               MetaField("file_type", "INT", "DEFAULT 0 NOT NULL"),

                                                               MetaField("file_size", "BIGINT", "DEFAULT 0 NOT NULL"),

                                                               MetaField("row_count", "BIGINT", "DEFAULT 0 NOT NULL"),

                                                               MetaField("updated_time", "BIGINT", "NOT NULL"),

                                                               MetaField("created_on", "BIGINT", "NOT NULL"),

                                                               MetaField("date", "INT", "DEFAULT -1 NOT NULL"),

                                                           });



}  // namespace

cpp/src/scheduler/task/SearchTask.cpp

+2 −2
Original line number Diff line number Diff line
@@ -157,8 +157,8 @@ XSearchTask::Load(LoadType type, uint8_t device_id) { 


    size_t file_size = index_engine_->PhysicalSize();



    std::string info = "Load file id:" + std::to_string(file_->id_) + " file type:" +

                       std::to_string(file_->file_type_) + " size:" + std::to_string(file_size) +

    std::string info = "Load file id:" + std::to_string(file_->id_) +

                       " file type:" + std::to_string(file_->file_type_) + " size:" + std::to_string(file_size) +

                       " bytes from location: " + file_->location_ + " totally cost";

    double span = rc.ElapseFromBegin(info);

    //    for (auto &context : search_contexts_) {