Commit 5bb337fd authored by groot's avatar groot
Browse files

refine code 


Former-commit-id: c1b6c9dfb6030c931f9958a642982f6254b7cc0b
parent f0f3a049

cpp/README.md

+6 −0
Original line number Original line Diff line number Diff line
@@ -121,9 +121,15 @@ $ sudo apt-get install clang-tidy clang-format 




$ rm cmake_build/CMakeCache.txt

$ rm cmake_build/CMakeCache.txt

```  

```  

Check code style

```shell

```shell

$ ./build.sh -l

$ ./build.sh -l

```

```

To format the code

```shell

$ cd cmake_build

$ make clang-format

```





##### Run unit test

##### Run unit test

cpp/build-support/lint_exclusions.txt

+2 −1
Original line number Original line Diff line number Diff line
@@ -6,3 +6,4 @@ 
*easylogging++*

*easylogging++*

*SqliteMetaImpl.cpp

*SqliteMetaImpl.cpp

*src/grpc*

*src/grpc*

*milvus/include*
 
 No newline at end of file

cpp/src/db/DBImpl.cpp

+66 −67
Original line number Original line Diff line number Diff line
@@ -26,9 +26,9 @@ 
#include "meta/SqliteMetaImpl.h"

#include "meta/SqliteMetaImpl.h"

#include "metrics/Metrics.h"

#include "metrics/Metrics.h"

#include "scheduler/SchedInst.h"

#include "scheduler/SchedInst.h"

#include "scheduler/job/BuildIndexJob.h"

#include "scheduler/job/DeleteJob.h"

#include "scheduler/job/DeleteJob.h"

#include "scheduler/job/SearchJob.h"

#include "scheduler/job/SearchJob.h"

#include "scheduler/job/BuildIndexJob.h"

#include "utils/Log.h"

#include "utils/Log.h"

#include "utils/TimeRecorder.h"

#include "utils/TimeRecorder.h"
@@ -900,8 +900,7 @@ DBImpl::BackgroundBuildIndex() { 
    meta_ptr_->FilesToIndex(to_index_files);

    meta_ptr_->FilesToIndex(to_index_files);

    Status status;

    Status status;





    scheduler::BuildIndexJobPtr

    scheduler::BuildIndexJobPtr job = std::make_shared<scheduler::BuildIndexJob>(0, meta_ptr_, options_);

        job = std::make_shared<scheduler::BuildIndexJob>(0, meta_ptr_, options_);





    // step 2: put build index task to scheduler

    // step 2: put build index task to scheduler

    for (auto& file : to_index_files) {

    for (auto& file : to_index_files) {

cpp/src/scheduler/TaskCreator.cpp

+8 −9
Original line number Original line Diff line number Diff line
@@ -15,12 +15,11 @@ 
// specific language governing permissions and limitations

// specific language governing permissions and limitations

// under the License.

// under the License.





#include <src/scheduler/tasklabel/SpecResLabel.h>

#include "scheduler/TaskCreator.h"

#include "scheduler/TaskCreator.h"

#include <src/scheduler/tasklabel/SpecResLabel.h>

#include "SchedInst.h"

#include "scheduler/tasklabel/BroadcastLabel.h"

#include "scheduler/tasklabel/BroadcastLabel.h"

#include "tasklabel/DefaultLabel.h"

#include "tasklabel/DefaultLabel.h"

#include "SchedInst.h"







namespace milvus {

namespace milvus {

namespace scheduler {

namespace scheduler {

cpp/src/scheduler/TaskCreator.h

+1 −1
Original line number Original line Diff line number Diff line
@@ -30,9 +30,9 @@ 
#include "job/DeleteJob.h"

#include "job/DeleteJob.h"

#include "job/Job.h"

#include "job/Job.h"

#include "job/SearchJob.h"

#include "job/SearchJob.h"

#include "task/BuildIndexTask.h"

#include "task/DeleteTask.h"

#include "task/DeleteTask.h"

#include "task/SearchTask.h"

#include "task/SearchTask.h"

#include "task/BuildIndexTask.h"

#include "task/Task.h"

#include "task/Task.h"





namespace milvus {

namespace milvus {