Commit a35d8909 authored by Matthew Zeng's avatar Matthew Zeng
Browse files

Fix typo

parent 77a60d56

README.md

+2 −2
Original line number Diff line number Diff line
@@ -163,8 +163,8 @@ EAF implements three major functionalities: 


### EAF vs EXWM?

1. EAF and EXWM share a common goal: enhance collaboration between the standard GNU Emacs with other GUI tools.

2. EXWM is an X11 Windows Manager, it manages and controls other software using a keyboard, but it cannot modify, customize and extend the behavior of other software. For example, it cannot modify the behavior when you press a key in Chrome or a PDF viewer.

3. EAF is *not* a Windows Manager, it utilizes the windows managing capabilities of Emacs to display its applications.

2. EXWM is an X11 Window Manager, it manages and controls other software using a keyboard, but it cannot modify, customize and extend the behavior of other software. For example, it cannot modify the behavior when you press a key in Chrome or a PDF viewer.

3. EAF is *not* a Window Manager, it utilizes the windows managing capabilities of Emacs to display its applications.

4. The intention of EAF is to provide a framework to write PyQt5 applications that extends the multimedia experience of Emacs. From the perspective of Emacs' buffer/mode design, EAF is not different from any other package, with the former uses Qt for drawing contents while the latter uses Emacs' built-in text libraries instead.

5. Through EAF's design, one can use Elisp to control Python and vice versa, and even able to use Elisp to control JavaScript in EAF Browser. EAF enables Emacs to the world of **multi-language scripting**.

core/browser.py

+5 −5
Original line number Diff line number Diff line
@@ -457,7 +457,7 @@ class BrowserBuffer(Buffer): 
            jsonrpc = Jsonrpc('localhost', 6800)

            resp = jsonrpc.addUris(download_url)



            self.message_to_emacs.emit("Start download: " + download_url)

            self.message_to_emacs.emit("Downloading: " + download_url)



    def destroy_buffer(self):

        # Record close page.
@@ -716,10 +716,10 @@ class BrowserBuffer(Buffer): 
                    file_type = "audio"



                with open(os.devnull, "w") as null_file:

                    popen_and_call(youtube_dl_args, lambda : self.message_to_emacs.emit("Finish download: {0}".format(url)), null_file)

                    popen_and_call(youtube_dl_args, lambda : self.message_to_emacs.emit("Downloaded: {0}".format(url)), null_file)



                self.message_to_emacs.emit("Start download {0}: {1}".format(file_type, url))

                self.message_to_emacs.emit("Downloading {0}: {1}".format(file_type, url))

            else:

                self.message_to_emacs.emit("Please install youtube-dl first.")

                self.message_to_emacs.emit("Please install youtube-dl to use this feature.")

        else:

            self.message_to_emacs.emit("Only can download video from YouTube now.")
 
            self.message_to_emacs.emit("Only videos from YouTube can be downloaded for now.")