Commit 4402cac0 authored by terrymanu's avatar terrymanu
Browse files

add ER_ERROR_ON_MODIFYING_GTID_EXECUTED_TABLE

parent 3539d132

sharding-proxy/src/main/java/io/shardingsphere/proxy/backend/common/jdbc/JDBCBackendHandler.java

+9 −7
Original line number Diff line number Diff line
@@ -37,6 +37,7 @@ import io.shardingsphere.proxy.backend.resource.BaseJDBCResource; 
import io.shardingsphere.proxy.config.RuleRegistry;

import io.shardingsphere.proxy.metadata.ProxyShardingRefreshHandler;

import io.shardingsphere.proxy.transport.common.packet.DatabaseProtocolPacket;

import io.shardingsphere.proxy.transport.mysql.constant.ServerErrorCode;

import io.shardingsphere.proxy.transport.mysql.constant.StatusFlag;

import io.shardingsphere.proxy.transport.mysql.packet.command.CommandResponsePackets;

import io.shardingsphere.proxy.transport.mysql.packet.command.text.query.FieldCountPacket;
@@ -104,19 +105,20 @@ public abstract class JDBCBackendHandler implements BackendHandler { 
    @Override

    public CommandResponsePackets execute() {

        try {

            return doExecuteInternal(ruleRegistry.isMasterSlaveOnly() ? doMasterSlaveRoute() : doShardingRoute());

            return execute(ruleRegistry.isMasterSlaveOnly() ? doMasterSlaveRoute() : doShardingRoute());

        } catch (final Exception ex) {

            log.error("ExecuteBackendHandler", ex);

            return new CommandResponsePackets(new ErrPacket(1, new SQLException(ex)));

        }

    }

    

    private CommandResponsePackets doExecuteInternal(final SQLRouteResult routeResult) throws SQLException, SystemException {

    private CommandResponsePackets execute(final SQLRouteResult routeResult) throws SQLException, SystemException {

        if (routeResult.getExecutionUnits().isEmpty()) {

            return new CommandResponsePackets(new OKPacket(1));

        }

        if (isXaDDL(routeResult)) {

            throw new SQLException("DDL command can't not execute in xa transaction mode.");

        if (isUnsupportedXA(routeResult.getSqlStatement().getType())) {

            return new CommandResponsePackets(new ErrPacket(1, ServerErrorCode.ER_ERROR_ON_MODIFYING_GTID_EXECUTED_TABLE, 

                    routeResult.getSqlStatement().getTables().isSingleTable() ? routeResult.getSqlStatement().getTables().getSingleTableName() : "unknown_table"));

        }

        ExecutorService executorService = ruleRegistry.getExecutorService();

        List<Future<CommandResponsePackets>> futureList = new ArrayList<>(1024);
@@ -132,9 +134,9 @@ public abstract class JDBCBackendHandler implements BackendHandler { 
        return result;

    }

    

    private boolean isXaDDL(final SQLRouteResult routeResult) throws SystemException {

        return TransactionType.XA.equals(ruleRegistry.getTransactionType())

                && SQLType.DDL.equals(routeResult.getSqlStatement().getType()) && Status.STATUS_NO_TRANSACTION != AtomikosUserTransaction.getInstance().getStatus();

    // TODO should isolate Atomikos API to SPI

    private boolean isUnsupportedXA(final SQLType sqlType) throws SystemException {

        return TransactionType.XA == ruleRegistry.getTransactionType() && SQLType.DDL == sqlType && Status.STATUS_NO_TRANSACTION != AtomikosUserTransaction.getInstance().getStatus();

    }

    

    private SQLRouteResult doMasterSlaveRoute() {

sharding-proxy/src/main/java/io/shardingsphere/proxy/transport/mysql/constant/ServerErrorCode.java

+5 −0
Original line number Diff line number Diff line
@@ -35,6 +35,11 @@ public enum ServerErrorCode { 
    

    ER_BAD_DB_ERROR(1049, "42000", "Unknown database '%s'"),

    

    ER_ERROR_ON_MODIFYING_GTID_EXECUTED_TABLE(3176, "HY000", 

            "Please do not modify the %s table with an XA transaction. "

                    + "This is an internal system table used to store GTIDs for committed transactions. "

                    + "Although modifying it can lead to an inconsistent GTID state, if neccessary you can modify it with a non-XA transaction."),

    

    ER_UNSUPPORTED_COMMAND(9999, "XXXXX", "Unsupported command packet: '%s'");

    

    private final int errorCode;