Unverified Commit 4032c4e6 authored by Tboy's avatar Tboy Committed by GitHub
Browse files

Merge pull request #1618 from samz406/1227-2 

before delete Udf check exist
parents d16500e8 96d49a09

dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/UdfFuncService.java

+7 −7
Original line number Diff line number Diff line
@@ -187,6 +187,12 @@ public class UdfFuncService extends BaseService{ 
        // verify udfFunc is exist

        UdfFunc udf = udfFuncMapper.selectUdfById(udfFuncId);



        if (udf == null) {

            result.put(Constants.STATUS, Status.UDF_FUNCTION_NOT_EXIST);

            result.put(Constants.MSG, Status.UDF_FUNCTION_NOT_EXIST.getMsg());

            return result;

        }



        // if resource upload startup

        if (!PropertyUtils.getResUploadStartupState()){

            logger.error("resource upload startup state: {}", PropertyUtils.getResUploadStartupState());
@@ -194,12 +200,6 @@ public class UdfFuncService extends BaseService{ 
            return result;

        }



        if (udf == null) {

            result.put(Constants.STATUS, Status.UDF_FUNCTION_NOT_EXIST);

            result.put(Constants.MSG, Status.UDF_FUNCTION_NOT_EXIST.getMsg());

            return result;

        }



        // verify udfFuncName is exist

        if (!funcName.equals(udf.getFuncName())) {

            if (checkUdfFuncNameExists(funcName)) {