Adapting partial code(file name start with P #2) to the sonar cloud rule (#2260) (eef8bf4e) · Commits · SUMMER2020 / students / proj-2002251

dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessInstanceController.java

+1 −1

Original line number	Diff line number	Diff line
		@@ -391,7 +391,7 @@ public class ProcessInstanceController extends BaseController{
		}
		}
		}
		if(deleteFailedIdList.size() > 0){
		if(!deleteFailedIdList.isEmpty()){
		putMsg(result, Status.BATCH_DELETE_PROCESS_INSTANCE_BY_IDS_ERROR, String.join(",", deleteFailedIdList));
		}else{
		putMsg(result, Status.SUCCESS);

dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/ProcessMeta.java

+0 −3

Original line number	Diff line number	Diff line
		@@ -106,9 +106,6 @@ public class ProcessMeta {
		*/
		private String scheduleWorkerGroupName;

		public ProcessMeta() {
		}

		public String getProjectName() {
		return projectName;
		}

dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessDefinitionService.java

+5 −8

Original line number	Diff line number	Diff line
		@@ -148,7 +148,7 @@ public class ProcessDefinitionService extends BaseDAGService {

		//custom global params
		List<Property> globalParamsList = processData.getGlobalParams();
		if (globalParamsList != null && globalParamsList.size() > 0) {
		if (CollectionUtils.isNotEmpty(globalParamsList)) {
		Set<Property> globalParamsSet = new HashSet<>(globalParamsList);
		globalParamsList = new ArrayList<>(globalParamsSet);
		processDefine.setGlobalParamList(globalParamsList);
		@@ -314,7 +314,7 @@ public class ProcessDefinitionService extends BaseDAGService {

		//custom global params
		List<Property> globalParamsList = new ArrayList<>();
		if (processData.getGlobalParams() != null && processData.getGlobalParams().size() > 0) {
		if (CollectionUtils.isNotEmpty(processData.getGlobalParams())) {
		Set<Property> userDefParamsSet = new HashSet<>(processData.getGlobalParams());
		globalParamsList = new ArrayList<>(userDefParamsSet);
		}
		@@ -453,12 +453,11 @@ public class ProcessDefinitionService extends BaseDAGService {
		ProcessDefinition processDefinition = processDefineMapper.selectById(id);

		switch (state) {
		case ONLINE: {
		case ONLINE:
		processDefinition.setReleaseState(state);
		processDefineMapper.updateById(processDefinition);
		break;
		}
		case OFFLINE: {
		case OFFLINE:
		processDefinition.setReleaseState(state);
		processDefineMapper.updateById(processDefinition);
		List<Schedule> scheduleList = scheduleMapper.selectAllByProcessDefineArray(
		@@ -473,12 +472,10 @@ public class ProcessDefinitionService extends BaseDAGService {
		SchedulerService.deleteSchedule(project.getId(), schedule.getId());
		}
		break;
		}
		default: {
		default:
		putMsg(result, Status.REQUEST_PARAMS_NOT_VALID_ERROR, "releaseState");
		return result;
		}
		}

		putMsg(result, Status.SUCCESS);
		return result;

dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessInstanceService.java

+7 −8

Original line number	Diff line number	Diff line
		@@ -239,7 +239,7 @@ public class ProcessInstanceService extends BaseDAGService {
		}
		ProcessInstance processInstance = processService.findProcessInstanceDetailById(processId);
		List<TaskInstance> taskInstanceList = processService.findValidTaskListByProcessId(processId);
		AddDependResultForTaskList(taskInstanceList);
		addDependResultForTaskList(taskInstanceList);
		Map<String, Object> resultMap = new HashMap<>();
		resultMap.put(PROCESS_INSTANCE_STATE, processInstance.getState().toString());
		resultMap.put(TASK_LIST, taskInstanceList);
		@@ -253,9 +253,9 @@ public class ProcessInstanceService extends BaseDAGService {
		* add dependent result for dependent task
		* @param taskInstanceList
		*/
		private void AddDependResultForTaskList(List<TaskInstance> taskInstanceList) throws IOException {
		private void addDependResultForTaskList(List<TaskInstance> taskInstanceList) throws IOException {
		for(TaskInstance taskInstance: taskInstanceList){
		if(taskInstance.getTaskType().toUpperCase().equals(TaskType.DEPENDENT.toString())){
		if(taskInstance.getTaskType().equalsIgnoreCase(TaskType.DEPENDENT.toString())){
		Result logResult = loggerService.queryLog(
		taskInstance.getId(), 0, 4098);
		if(logResult.getCode() == Status.SUCCESS.ordinal()){
		@@ -414,11 +414,10 @@ public class ProcessInstanceService extends BaseDAGService {
		processInstance.setProcessInstanceJson(processInstanceJson);
		processInstance.setGlobalParams(globalParams);
		}
		// int update = processDao.updateProcessInstance(processInstanceId, processInstanceJson,
		// globalParams, schedule, flag, locations, connects);

		int update = processService.updateProcessInstance(processInstance);
		int updateDefine = 1;
		if (syncDefine && StringUtils.isNotEmpty(processInstanceJson)) {
		if (Boolean.TRUE.equals(syncDefine) && StringUtils.isNotEmpty(processInstanceJson)) {
		processDefinition.setProcessDefinitionJson(processInstanceJson);
		processDefinition.setGlobalParams(originDefParams);
		processDefinition.setLocations(locations);
		@@ -544,7 +543,7 @@ public class ProcessInstanceService extends BaseDAGService {
		nodeValueSb.append(ipSb);
		}

		logger.info("delete task queue node : {}",nodeValueSb.toString());
		logger.info("delete task queue node : {}",nodeValueSb);
		tasksQueue.removeNode(org.apache.dolphinscheduler.common.Constants.DOLPHINSCHEDULER_TASKS_QUEUE, nodeValueSb.toString());

		}
		@@ -621,7 +620,7 @@ public class ProcessInstanceService extends BaseDAGService {
		Map<String,Object> localParamsMap = new HashMap<>();
		localParamsMap.put("taskType",taskNode.getType());
		localParamsMap.put("localParamsList",localParamsList);
		if (localParamsList.size() > 0) {
		if (CollectionUtils.isNotEmpty(localParamsList)) {
		localUserDefParams.put(taskNode.getName(), localParamsMap);
		}
		}

dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/process/ProcessEnvironmentForWin32.java

+13 −7

Original line number	Diff line number	Diff line
		@@ -46,22 +46,23 @@ final class ProcessEnvironmentForWin32 extends HashMap<String,String> {
		return (String) o;
		}

		@Override
		public String put(String key, String value) {
		return super.put(validateName(key), validateValue(value));
		}

		@Override
		public String get(Object key) {
		return super.get(nonNullString(key));
		}

		@Override
		public boolean containsKey(Object key) {
		return super.containsKey(nonNullString(key));
		}

		@Override
		public boolean containsValue(Object value) {
		return super.containsValue(nonNullString(value));
		}

		@Override
		public String remove(Object key) {
		return super.remove(nonNullString(key));
		}
		@@ -92,6 +93,7 @@ final class ProcessEnvironmentForWin32 extends HashMap<String,String> {
		public Entry<String,String> next() {
		return new CheckedEntry(i.next());
		}
		@Override
		public void remove() { i.remove();}
		};
		}
		@@ -110,10 +112,14 @@ final class ProcessEnvironmentForWin32 extends HashMap<String,String> {
		private final Collection<String> c;
		public CheckedValues(Collection<String> c) {this.c = c;}
		public int size() {return c.size();}
		@Override
		public boolean isEmpty() {return c.isEmpty();}
		@Override
		public void clear() { c.clear();}
		public Iterator<String> iterator() {return c.iterator();}
		@Override
		public boolean contains(Object o) {return c.contains(nonNullString(o));}
		@Override
		public boolean remove(Object o) {return c.remove(nonNullString(o));}
		}

		@@ -127,15 +133,15 @@ final class ProcessEnvironmentForWin32 extends HashMap<String,String> {
		public boolean contains(Object o) {return s.contains(nonNullString(o));}
		public boolean remove(Object o) {return s.remove(nonNullString(o));}
		}

		@Override
		public Set<String> keySet() {
		return new CheckedKeySet(super.keySet());
		}

		@Override
		public Collection<String> values() {
		return new CheckedValues(super.values());
		}

		@Override
		public Set<Entry<String,String>> entrySet() {
		return new CheckedEntrySet(super.entrySet());
		}