Unverified Commit 933a67db authored by CalvinKirs's avatar CalvinKirs Committed by GitHub
Browse files

[Improvement][Server]Code Clean (#3196) 

* [*][Server]Code Clean
redundant code removal

* redundant code removal

* redundant code removal
parent c49626b8

dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/registry/ZookeeperNodeManager.java

+0 −6
Original line number Diff line number Diff line
@@ -131,16 +131,12 @@ public class ZookeeperNodeManager implements InitializingBean { 
                    if (event.getType() == TreeCacheEvent.Type.NODE_ADDED) {

                        logger.info("worker group node : {} added.", path);

                        String group = parseGroup(path);

                        Set<String> workerNodes = workerGroupNodes.getOrDefault(group, new HashSet<>());

                        Set<String> previousNodes = new HashSet<>(workerNodes);

                        Set<String> currentNodes = registryCenter.getWorkerGroupNodesDirectly(group);

                        logger.info("currentNodes : {}", currentNodes);

                        syncWorkerGroupNodes(group, currentNodes);

                    } else if (event.getType() == TreeCacheEvent.Type.NODE_REMOVED) {

                        logger.info("worker group node : {} down.", path);

                        String group = parseGroup(path);

                        Set<String> workerNodes = workerGroupNodes.getOrDefault(group, new HashSet<>());

                        Set<String> previousNodes = new HashSet<>(workerNodes);

                        Set<String> currentNodes = registryCenter.getWorkerGroupNodesDirectly(group);

                        syncWorkerGroupNodes(group, currentNodes);

                        alertDao.sendServerStopedAlert(1, path, "WORKER");
@@ -175,12 +171,10 @@ public class ZookeeperNodeManager implements InitializingBean { 
                try {

                    if (event.getType() == TreeCacheEvent.Type.NODE_ADDED) {

                        logger.info("master node : {} added.", path);

                        Set<String> previousNodes = new HashSet<>(masterNodes);

                        Set<String> currentNodes = registryCenter.getMasterNodesDirectly();

                        syncMasterNodes(currentNodes);

                    } else if (event.getType() == TreeCacheEvent.Type.NODE_REMOVED) {

                        logger.info("master node : {} down.", path);

                        Set<String> previousNodes = new HashSet<>(masterNodes);

                        Set<String> currentNodes = registryCenter.getMasterNodesDirectly();

                        syncMasterNodes(currentNodes);

                        alertDao.sendServerStopedAlert(1, path, "MASTER");