Unverified Commit 78856fb0 authored by zixi0825's avatar zixi0825 Committed by GitHub
Browse files

remove the duplicate function in MasterExecThread (#3329) 



Co-authored-by: default avatarsunchaohe <sunzhaohe@linklogis.com>
parent afeeb34d

dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java

+1 −19
Original line number Diff line number Diff line
@@ -802,7 +802,7 @@ public class MasterExecThread implements Runnable { 
        ProcessInstance instance = processService.findProcessInstanceById(processInstance.getId());

        ExecutionStatus state = instance.getState();



        if(activeTaskNode.size() > 0 || retryTaskExists()){

        if(activeTaskNode.size() > 0 || hasRetryTaskInStandBy()){

            // active task and retry task exists

            return runningState(state);

        }
@@ -852,24 +852,6 @@ public class MasterExecThread implements Runnable { 
        return state;

    }



    /**

     * whether standby task list have retry tasks

     * @return

     */

    private boolean retryTaskExists() {



        boolean result = false;



        for(String taskName : readyToSubmitTaskList.keySet()){

            TaskInstance task = readyToSubmitTaskList.get(taskName);

            if(task.getState().typeIsFailure()){

                result = true;

                break;

            }

        }

        return result;

    }



    /**

     * whether complement end

     * @return Boolean whether is complement end