Commit 503be5f4 authored by samz406's avatar samz406 Committed by dailidong
Browse files

add service UT (#1637) 

* User update  not check params

* user phone update when noteEmpty

* modify saveWorkerGroup may NPE

* add some service UT

* add  service ut include
parent 6d4a3410

dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/AccessTokenServiceTest.java

0 → 100644
+181 −0
Original line number Diff line number Diff line 
/*

 * Licensed to the Apache Software Foundation (ASF) under one or more

 * contributor license agreements.  See the NOTICE file distributed with

 * this work for additional information regarding copyright ownership.

 * The ASF licenses this file to You under the Apache License, Version 2.0

 * (the "License"); you may not use this file except in compliance with

 * the License.  You may obtain a copy of the License at

 *

 *    http://www.apache.org/licenses/LICENSE-2.0

 *

 * Unless required by applicable law or agreed to in writing, software

 * distributed under the License is distributed on an "AS IS" BASIS,

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 * See the License for the specific language governing permissions and

 * limitations under the License.

 */

package org.apache.dolphinscheduler.api.service;



import com.baomidou.mybatisplus.core.metadata.IPage;

import com.baomidou.mybatisplus.extension.plugins.pagination.Page;

import org.apache.commons.lang3.time.DateUtils;

import org.apache.dolphinscheduler.api.enums.Status;

import org.apache.dolphinscheduler.api.utils.PageInfo;

import org.apache.dolphinscheduler.common.Constants;

import org.apache.dolphinscheduler.common.enums.UserType;

import org.apache.dolphinscheduler.dao.entity.AccessToken;

import org.apache.dolphinscheduler.dao.entity.User;

import org.apache.dolphinscheduler.dao.mapper.AccessTokenMapper;

import org.junit.After;

import org.junit.Assert;

import org.junit.Before;

import org.junit.Test;

import org.junit.runner.RunWith;

import org.mockito.InjectMocks;

import org.mockito.Mock;

import org.mockito.junit.MockitoJUnitRunner;

import org.slf4j.Logger;

import org.slf4j.LoggerFactory;



import java.util.ArrayList;

import java.util.Date;

import java.util.List;

import java.util.Map;



import static org.mockito.ArgumentMatchers.any;

import static org.mockito.ArgumentMatchers.eq;

import static org.mockito.Mockito.when;



@RunWith(MockitoJUnitRunner.class)

public class AccessTokenServiceTest {





    private static final Logger logger = LoggerFactory.getLogger(AccessTokenServiceTest.class);





    @InjectMocks

    private AccessTokenService accessTokenService ;



    @Mock

    private AccessTokenMapper accessTokenMapper;



    @Before

    public void setUp() {



    }





    @After

    public void after(){



    }







    @Test

    public  void testQueryAccessTokenList(){



        IPage<AccessToken> tokenPage = new Page<>();

        tokenPage.setRecords(getList());

        tokenPage.setTotal(1L);

        when(accessTokenMapper.selectAccessTokenPage(any(Page.class),eq("zhangsan"),eq(0))).thenReturn(tokenPage);



        User user =new User();

        Map<String, Object> result = accessTokenService.queryAccessTokenList(user,"zhangsan",1,10);

        logger.info(result.toString());

        Assert.assertEquals(Status.SUCCESS,result.get(Constants.STATUS));

        PageInfo<AccessToken> pageInfo = (PageInfo<AccessToken>) result.get(Constants.DATA_LIST);

        Assert.assertTrue(pageInfo.getTotalCount()>0);

    }



    @Test

    public  void testCreateToken(){





       when(accessTokenMapper.insert(any(AccessToken.class))).thenReturn(2);

        Map<String, Object> result = accessTokenService.createToken(1,getDate(),"AccessTokenServiceTest");

        logger.info(result.toString());

        Assert.assertEquals(Status.SUCCESS,result.get(Constants.STATUS));

    }



    @Test

    public  void testGenerateToken(){



        Map<String, Object> result = accessTokenService.generateToken(Integer.MAX_VALUE,getDate());

        logger.info(result.toString());

        Assert.assertEquals(Status.SUCCESS,result.get(Constants.STATUS));

        String token = (String) result.get(Constants.DATA_LIST);

        Assert.assertNotNull(token);

    }



    @Test

    public  void testDelAccessTokenById(){



        when(accessTokenMapper.selectById(1)).thenReturn(getEntity());

        User userLogin = new User();

        // not exist

        Map<String, Object> result = accessTokenService.delAccessTokenById(userLogin,0);

        logger.info(result.toString());

        Assert.assertEquals(Status.ACCESS_TOKEN_NOT_EXIST,result.get(Constants.STATUS));

        // no operate

        result = accessTokenService.delAccessTokenById(userLogin,1);

        logger.info(result.toString());

        Assert.assertEquals(Status.USER_NO_OPERATION_PERM,result.get(Constants.STATUS));

        //success

        userLogin.setId(1);

        userLogin.setUserType(UserType.ADMIN_USER);

        result = accessTokenService.delAccessTokenById(userLogin,1);

        logger.info(result.toString());

        Assert.assertEquals(Status.SUCCESS,result.get(Constants.STATUS));

    }



    @Test

    public  void testUpdateToken(){



        when(accessTokenMapper.selectById(1)).thenReturn(getEntity());

        Map<String, Object> result = accessTokenService.updateToken(1,Integer.MAX_VALUE,getDate(),"token");

        logger.info(result.toString());

        Assert.assertEquals(Status.SUCCESS,result.get(Constants.STATUS));

        // not exist

        result = accessTokenService.updateToken(2,Integer.MAX_VALUE,getDate(),"token");

        logger.info(result.toString());

        Assert.assertEquals(Status.ACCESS_TOKEN_NOT_EXIST,result.get(Constants.STATUS));



    }



    /**

     * create entity

     * @return

     */

    private AccessToken getEntity(){

        AccessToken accessToken = new AccessToken();

        accessToken.setId(1);

        accessToken.setUserId(1);

        accessToken.setToken("AccessTokenServiceTest");

        Date date = DateUtils.addDays(new Date(),30);

        accessToken.setExpireTime(date);

        return accessToken;

    }



    /**

     * entity list

     * @return

     */

    private List<AccessToken> getList(){



        List<AccessToken> list = new ArrayList<>();

        list.add(getEntity());

        return list;

    }







    /**

     * get dateStr

     * @return

     */

    private String getDate(){

        Date date = DateUtils.addDays(new Date(),30);

       return org.apache.dolphinscheduler.common.utils.DateUtils.dateToString(date);

    }

}

dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/AlertGroupServiceTest.java

0 → 100644
+219 −0
Original line number Diff line number Diff line 
/*

 * Licensed to the Apache Software Foundation (ASF) under one or more

 * contributor license agreements.  See the NOTICE file distributed with

 * this work for additional information regarding copyright ownership.

 * The ASF licenses this file to You under the Apache License, Version 2.0

 * (the "License"); you may not use this file except in compliance with

 * the License.  You may obtain a copy of the License at

 *

 *    http://www.apache.org/licenses/LICENSE-2.0

 *

 * Unless required by applicable law or agreed to in writing, software

 * distributed under the License is distributed on an "AS IS" BASIS,

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 * See the License for the specific language governing permissions and

 * limitations under the License.

 */

package org.apache.dolphinscheduler.api.service;



import com.baomidou.mybatisplus.core.metadata.IPage;

import com.baomidou.mybatisplus.extension.plugins.pagination.Page;

import org.apache.dolphinscheduler.api.enums.Status;

import org.apache.dolphinscheduler.api.utils.PageInfo;

import org.apache.dolphinscheduler.api.utils.Result;

import org.apache.dolphinscheduler.common.Constants;

import org.apache.dolphinscheduler.common.enums.AlertType;

import org.apache.dolphinscheduler.common.enums.UserType;

import org.apache.dolphinscheduler.common.utils.CollectionUtils;

import org.apache.dolphinscheduler.dao.entity.AlertGroup;

import org.apache.dolphinscheduler.dao.entity.User;

import org.apache.dolphinscheduler.dao.mapper.AlertGroupMapper;

import org.apache.dolphinscheduler.dao.mapper.UserAlertGroupMapper;

import org.junit.After;

import org.junit.Assert;

import org.junit.Before;

import org.junit.Test;

import org.junit.runner.RunWith;

import org.mockito.InjectMocks;

import org.mockito.Mock;

import org.mockito.Mockito;

import org.mockito.junit.MockitoJUnitRunner;

import org.slf4j.Logger;

import org.slf4j.LoggerFactory;



import java.util.ArrayList;

import java.util.HashMap;

import java.util.List;

import java.util.Map;



import static org.mockito.ArgumentMatchers.any;

import static org.mockito.ArgumentMatchers.eq;



@RunWith(MockitoJUnitRunner.class)

public class AlertGroupServiceTest {



    private static final Logger logger = LoggerFactory.getLogger(AlertGroupServiceTest.class);



    @InjectMocks

    private AlertGroupService alertGroupService;

    @Mock

    private AlertGroupMapper alertGroupMapper;

    @Mock

    private UserAlertGroupMapper userAlertGroupMapper;



    private String groupName = "AlertGroupServiceTest";



    @Before

    public void setUp() {

    }





    @After

    public void after(){



    }







    @Test

    public  void testQueryAlertgroup(){



        Mockito.when(alertGroupMapper.queryAllGroupList()).thenReturn(getList());

        HashMap<String, Object> result= alertGroupService.queryAlertgroup();

        logger.info(result.toString());

        List<AlertGroup> alertGroups = (List<AlertGroup>) result.get(Constants.DATA_LIST);

        Assert.assertTrue(CollectionUtils.isNotEmpty(alertGroups));

    }

    @Test

    public  void testListPaging(){

        IPage<AlertGroup> page = new Page<>(1,10);

        page.setTotal(1L);

        page.setRecords(getList());

        Mockito.when(alertGroupMapper.queryAlertGroupPage(any(Page.class),eq(groupName))).thenReturn(page);

        User user = new User();

        // no operate

        Map<String, Object> result = alertGroupService.listPaging(user,groupName,1,10);

        logger.info(result.toString());

        Assert.assertEquals(Status.USER_NO_OPERATION_PERM,result.get(Constants.STATUS));

        //success

        user.setUserType(UserType.ADMIN_USER);

        result = alertGroupService.listPaging(user,groupName,1,10);

        logger.info(result.toString());

        PageInfo<AlertGroup> pageInfo = (PageInfo<AlertGroup>) result.get(Constants.DATA_LIST);

        Assert.assertTrue(CollectionUtils.isNotEmpty(pageInfo.getLists()));



    }

    @Test

    public  void testCreateAlertgroup(){





        Mockito.when(alertGroupMapper.insert(any(AlertGroup.class))).thenReturn(2);

        User user = new User();

        //no operate

        Map<String, Object>  result = alertGroupService.createAlertgroup(user,groupName, AlertType.EMAIL,groupName);

        logger.info(result.toString());

        Assert.assertEquals(Status.USER_NO_OPERATION_PERM,result.get(Constants.STATUS));

        user.setUserType(UserType.ADMIN_USER);

        //success

        result = alertGroupService.createAlertgroup(user,groupName, AlertType.EMAIL,groupName);

        logger.info(result.toString());

        Assert.assertEquals(Status.SUCCESS,result.get(Constants.STATUS));

    }

    @Test

    public  void testUpdateAlertgroup(){



        User user = new User();

        // no operate

        Map<String, Object>  result = alertGroupService.updateAlertgroup(user,1,groupName, AlertType.SMS,groupName);

        logger.info(result.toString());

        Assert.assertEquals(Status.USER_NO_OPERATION_PERM,result.get(Constants.STATUS));

        user.setUserType(UserType.ADMIN_USER);

        // not exist

        result = alertGroupService.updateAlertgroup(user,1,groupName, AlertType.SMS,groupName);

        logger.info(result.toString());

        Assert.assertEquals(Status.ALERT_GROUP_NOT_EXIST,result.get(Constants.STATUS));

        //success

        Mockito.when(alertGroupMapper.selectById(2)).thenReturn(getEntity());

        result = alertGroupService.updateAlertgroup(user,2,groupName, AlertType.SMS,groupName);

        logger.info(result.toString());

        Assert.assertEquals(Status.SUCCESS,result.get(Constants.STATUS));



    }

    @Test

    public  void testDelAlertgroupById(){



        User user = new User();

        // no operate

        Map<String, Object>  result = alertGroupService.delAlertgroupById(user,1);

        logger.info(result.toString());

        Assert.assertEquals(Status.USER_NO_OPERATION_PERM,result.get(Constants.STATUS));

        user.setUserType(UserType.ADMIN_USER);

        // not exist

        result = alertGroupService.delAlertgroupById(user,2);

        logger.info(result.toString());

        Assert.assertEquals(Status.ALERT_GROUP_NOT_EXIST,result.get(Constants.STATUS));

        //success

        Mockito.when(alertGroupMapper.selectById(2)).thenReturn(getEntity());

        result = alertGroupService.delAlertgroupById(user,2);

        logger.info(result.toString());

        Assert.assertEquals(Status.SUCCESS,result.get(Constants.STATUS));





    }

    @Test

    public  void testGrantUser(){



        Map<String, Object>  result = alertGroupService.grantUser(getLoginUser(),1,"123,321");

        logger.info(result.toString());

        Assert.assertEquals(Status.SUCCESS,result.get(Constants.STATUS));

    }

    @Test

    public  void testVerifyGroupName(){

        //group name not exist

        Result result = alertGroupService.verifyGroupName(getLoginUser(), groupName);

        logger.info(result.toString());

        Assert.assertEquals(Status.SUCCESS.getMsg(),result.getMsg());

        Mockito.when(alertGroupMapper.queryByGroupName(groupName)).thenReturn(getList());



        //group name exist

        result = alertGroupService.verifyGroupName(getLoginUser(), groupName);

        logger.info(result.toString());

        Assert.assertEquals(Status.ALERT_GROUP_EXIST.getMsg(),result.getMsg());

    }





    /**

     * create admin user

     * @return

     */

    private User getLoginUser(){



        User loginUser = new User();

        loginUser.setUserType(UserType.ADMIN_USER);

        loginUser.setId(99999999);

        return loginUser;

    }



    /**

     * get list

     * @return

     */

    private List<AlertGroup> getList(){

        List<AlertGroup> alertGroups = new ArrayList<>();

        alertGroups.add(getEntity());

        return alertGroups;

    }



    /**

     * get entity

     * @return

     */

    private AlertGroup getEntity(){

        AlertGroup alertGroup = new AlertGroup();

        alertGroup.setId(1);

        alertGroup.setGroupName(groupName);

        alertGroup.setGroupType(AlertType.EMAIL);

        return alertGroup;

    }



}

dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/MonitorServiceTest.java

0 → 100644
+101 −0
Original line number Diff line number Diff line 
/*

 * Licensed to the Apache Software Foundation (ASF) under one or more

 * contributor license agreements.  See the NOTICE file distributed with

 * this work for additional information regarding copyright ownership.

 * The ASF licenses this file to You under the Apache License, Version 2.0

 * (the "License"); you may not use this file except in compliance with

 * the License.  You may obtain a copy of the License at

 *

 *    http://www.apache.org/licenses/LICENSE-2.0

 *

 * Unless required by applicable law or agreed to in writing, software

 * distributed under the License is distributed on an "AS IS" BASIS,

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 * See the License for the specific language governing permissions and

 * limitations under the License.

 */

package org.apache.dolphinscheduler.api.service;



import org.apache.dolphinscheduler.api.enums.Status;

import org.apache.dolphinscheduler.common.Constants;

import org.apache.dolphinscheduler.common.enums.DbType;

import org.apache.dolphinscheduler.common.model.Server;

import org.apache.dolphinscheduler.common.utils.CollectionUtils;

import org.apache.dolphinscheduler.dao.MonitorDBDao;

import org.apache.dolphinscheduler.dao.entity.MonitorRecord;

import org.junit.Assert;

import org.junit.Test;

import org.junit.runner.RunWith;

import org.mockito.InjectMocks;

import org.mockito.Mock;

import org.mockito.Mockito;

import org.mockito.junit.MockitoJUnitRunner;

import org.slf4j.Logger;

import org.slf4j.LoggerFactory;



import java.util.ArrayList;

import java.util.List;

import java.util.Map;



@RunWith(MockitoJUnitRunner.class)

public class MonitorServiceTest {



    private static final Logger logger = LoggerFactory.getLogger(MonitorServiceTest.class);



    @InjectMocks

    private MonitorService monitorService;

    @Mock

    private MonitorDBDao monitorDBDao;





    @Test

    public  void testQueryDatabaseState(){



        Mockito.when(monitorDBDao.queryDatabaseState()).thenReturn(getList());

        Map<String,Object> result = monitorService.queryDatabaseState(null);

        logger.info(result.toString());

        Assert.assertEquals(Status.SUCCESS,result.get(Constants.STATUS));

        List<MonitorRecord> monitorRecordList = (List<MonitorRecord>) result.get(Constants.DATA_LIST);

        Assert.assertTrue(CollectionUtils.isNotEmpty(monitorRecordList));

    }

    @Test

    public  void testQueryMaster(){

        //TODO need zk

//        Map<String,Object> result = monitorService.queryMaster(null);

//        logger.info(result.toString());

//        Assert.assertEquals(Status.SUCCESS,result.get(Constants.STATUS));

    }

    @Test

    public  void testQueryZookeeperState(){

        //TODO need zk

//        Map<String,Object> result = monitorService.queryZookeeperState(null);

//        logger.info(result.toString());

//        Assert.assertEquals(Status.SUCCESS,result.get(Constants.STATUS));

    }



    @Test

    public  void testGetServerListFromZK(){

        //TODO need zk

//        List<Server> serverList = monitorService.getServerListFromZK(true);

//        logger.info(serverList.toString());

    }



    private List<MonitorRecord> getList(){

        List<MonitorRecord> monitorRecordList = new ArrayList<>();

        monitorRecordList.add(getEntity());

        return monitorRecordList;

    }



    private MonitorRecord getEntity(){

        MonitorRecord monitorRecord = new  MonitorRecord();

        monitorRecord.setDbType(DbType.MYSQL);

        return monitorRecord;

    }



    private List<Server> getServerList(){

        List<Server> servers = new ArrayList<>();

        servers.add(new Server());

        return servers;

    }



}

dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/ProjectServiceTest.java

0 → 100644
+356 −0

File added.

Preview size limit exceeded, changes collapsed.

dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/QueueServiceTest.java

0 → 100644
+208 −0

File added.

Preview size limit exceeded, changes collapsed.