Skip to content
Commit f9b0e058 authored by Jan Kara's avatar Jan Kara Committed by Fengguang Wu
Browse files

writeback: Fix data corruption on NFS



Commit 4f8ad655 "writeback: Refactor writeback_single_inode()" added
a condition to skip clean inode. However this is wrong in WB_SYNC_ALL
mode because there we also want to wait for outstanding writeback on
possibly clean inode. This was causing occasional data corruption issues
on NFS because it uses sync_inode() to make sure all outstanding writes
are flushed to the server before truncating the inode and with
sync_inode() returning prematurely file was sometimes extended back
by an outstanding write after it was truncated.

So modify the test to also check for pages under writeback in
WB_SYNC_ALL mode.

CC: stable@vger.kernel.org # >= 3.5
Fixes: 4f8ad655
Reported-and-tested-by: default avatarDan Duval <dan.duval@oracle.com>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent 374b1057
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment