Skip to content
Commit 84338569 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mimi Zohar
Browse files

evm: Fix a small race in init_desc()



The IS_ERR_OR_NULL() function has two conditions and if we got really
unlucky we could hit a race where "ptr" started as an error pointer and
then was set to NULL.  Both conditions would be false even though the
pointer at the end was NULL.

This patch fixes the problem by ensuring that "*tfm" can only be NULL
or valid.  I have introduced a "tmp_tfm" variable to make that work.  I
also reversed a condition and pulled the code in one tab.

Reported-by: default avatarRoberto Sassu <roberto.sassu@huawei.com>
Fixes: 53de3b08 ("evm: Check also if *tfm is an error pointer in init_desc()")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarRoberto Sassu <roberto.sassu@huawei.com>
Acked-by: default avatarKrzysztof Struczynski <krzysztof.struczynski@huawei.com>
Signed-off-by: default avatarMimi Zohar <zohar@linux.ibm.com>
parent 770f6058
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment