Skip to content
Commit ff04f3b6 authored by Ard Biesheuvel's avatar Ard Biesheuvel
Browse files

efivarfs: revert "fix memory leak in efivarfs_create()"



The memory leak addressed by commit fe5186cf is a false positive:
all allocations are recorded in a linked list, and freed when the
filesystem is unmounted. This leads to double frees, and as reported
by David, leads to crashes if SLUB is configured to self destruct when
double frees occur.

So drop the redundant kfree() again, and instead, mark the offending
pointer variable so the allocation is ignored by kmemleak.

Cc: Vamshi K Sthambamkadi <vamshi.k.sthambamkadi@gmail.com>
Fixes: fe5186cf ("efivarfs: fix memory leak in efivarfs_create()")
Reported-by: default avatarDavid Laight <David.Laight@aculab.com>
Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
parent 50bdcf04
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment