Skip to content
Commit e8183fa1 authored by Tam Nguyen's avatar Tam Nguyen Committed by Wolfram Sang
Browse files

i2c: designware: Disable TX_EMPTY irq while waiting for block length byte



During SMBus block data read process, we have seen high interrupt rate
because of TX_EMPTY irq status while waiting for block length byte (the
first data byte after the address phase). The interrupt handler does not
do anything because the internal state is kept as STATUS_WRITE_IN_PROGRESS.
Hence, we should disable TX_EMPTY IRQ until I2C DesignWare receives
first data byte from I2C device, then re-enable it to resume SMBus
transaction.

It takes 0.789 ms for host to receive data length from slave.
Without the patch, i2c_dw_isr() is called 99 times by TX_EMPTY interrupt.
And it is none after applying the patch.

Cc: stable@vger.kernel.org
Co-developed-by: default avatarChuong Tran <chuong@os.amperecomputing.com>
Signed-off-by: default avatarChuong Tran <chuong@os.amperecomputing.com>
Signed-off-by: default avatarTam Nguyen <tamnguyenchi@os.amperecomputing.com>
Acked-by: default avatarJarkko Nikula <jarkko.nikula@linux.intel.com>
Reviewed-by: default avatarSerge Semin <fancer.lancer@gmail.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent ba15a143
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment