Skip to content
Commit d50b3f43 authored by Max Staudt's avatar Max Staudt Committed by Tomi Valkeinen
Browse files

fbdev/efifb: Fix 16 color palette entry calculation

When using efifb with a 16-bit (5:6:5) visual, fbcon's text is rendered
in the wrong colors - e.g. text gray (#aaaaaa) is rendered as green
(#50bc50) and neighboring pixels have slightly different values
(such as #50bc78).

The reason is that fbcon loads its 16 color palette through
efifb_setcolreg(), which in turn calculates a 32-bit value to write
into memory for each palette index.
Until now, this code could only handle 8-bit visuals and didn't mask
overlapping values when ORing them.

With this patch, fbcon displays the correct colors when a qemu VM is
booted in 16-bit mode (in GRUB: "set gfxpayload=800x600x16").

Fixes: 7c83172b

 ("x86_64 EFI boot support: EFI frame buffer driver")  # v2.6.24+
Signed-off-by: default avatarMax Staudt <mstaudt@suse.de>
Acked-By: default avatarPeter Jones <pjones@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 71668292
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment