Skip to content
Commit d24b0353 authored by Ryosuke Yasuoka's avatar Ryosuke Yasuoka Committed by David S. Miller
Browse files

nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet

syzbot reported the following uninit-value access issue [1][2]:

nci_rx_work() parses and processes received packet. When the payload
length is zero, each message type handler reads uninitialized payload
and KMSAN detects this issue. The receipt of a packet with a zero-size
payload is considered unexpected, and therefore, such packets should be
silently discarded.

This patch resolved this issue by checking payload size before calling
each message type handler codes.

Fixes: 6a2968aa

 ("NFC: basic NCI protocol implementation")
Reported-and-tested-by: default avatar <syzbot+7ea9413ea6749baf5574@syzkaller.appspotmail.com>
Reported-and-tested-by: default avatar <syzbot+29b5ca705d2e0f4a44d2@syzkaller.appspotmail.com>
Closes: https://syzkaller.appspot.com/bug?extid=7ea9413ea6749baf5574 [1]
Closes: https://syzkaller.appspot.com/bug?extid=29b5ca705d2e0f4a44d2

 [2]
Signed-off-by: default avatarRyosuke Yasuoka <ryasuoka@redhat.com>
Reviewed-by: default avatarJeremy Cline <jeremy@jcline.org>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cba9ffdb
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment